Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor [Fs/Blob]DataProvider to unify Serde support #837

Closed
sffc opened this issue Jun 29, 2021 · 2 comments · Fixed by #1369
Closed

Refactor [Fs/Blob]DataProvider to unify Serde support #837

sffc opened this issue Jun 29, 2021 · 2 comments · Fixed by #1369
Assignees
@sffc
Labels
blocked A dependency must be resolved before this is actionable C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2021 Q4 0.5 Sprint C

Comments

@sffc
Copy link
Member

sffc commented Jun 29, 2021

Currently there is some Serde code that is duplicated between these two modules. Once #829 is finished, we should refactor these two classes to share the deserialization code.
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Jun 29, 2021
@sffc sffc self-assigned this Jun 29, 2021
@sffc sffc added the blocked A dependency must be resolved before this is actionable label Jun 29, 2021
@sffc sffc added this to the ICU4X 0.4 milestone Jul 15, 2021
@sffc sffc modified the milestones: ICU4X 0.4, 2021 Q3 0.4 Sprint B Aug 11, 2021
@sffc
Copy link
Member Author

sffc commented Sep 8, 2021

Blocked on rust-lang/rust#85499 landing in stable.

@sffc sffc modified the milestones: 2021 Q3 0.4 Sprint B, ICU4X 0.5 Sep 8, 2021
@sffc sffc mentioned this issue Sep 22, 2021
Merged
@sffc sffc mentioned this issue Oct 31, 2021
Closed
2 tasks
@sffc sffc mentioned this issue Nov 24, 2021
Closed
@sffc sffc modified the milestones: ICU4X 0.5, 2021 Q4 0.5 Sprint C Nov 24, 2021
@sffc
Copy link
Member Author

sffc commented Nov 24, 2021

Blocked on #1246

@sffc sffc mentioned this issue Dec 8, 2021
Merged
@sffc sffc closed this as completed in #1369 Dec 9, 2021
@sffc sffc added S-medium Size: Less than a week (larger bug fix or enhancement) and removed S-small Size: One afternoon (small bug fix or enhancement) labels Dec 9, 2021
@sffc sffc mentioned this issue Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
blocked A dependency must be resolved before this is actionable C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2021 Q4 0.5 Sprint C
Development

Successfully merging a pull request may close this issue.

Replace SerdeDeDataProvider with BufferProvider sffc/omnicu
1 participant
@sffc