Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocaleCanonicalizer and LocaleDirectionality should use AsRef for their type parameter #5297

Open
sffc opened this issue Jul 25, 2024 · 1 comment · Fixed by #5704
Open

LocaleCanonicalizer and LocaleDirectionality should use AsRef for their type parameter #5297

sffc opened this issue Jul 25, 2024 · 1 comment · Fixed by #5704
Assignees
@Manishearth
Labels
2.0-breaking Changes that are breaking API changes S-small Size: One afternoon (small bug fix or enhancement)
Milestone
ICU4X 2.0 Stretch...

Comments

@sffc
Copy link
Member

sffc commented Jul 25, 2024

In #4140 we decided to move forward with an approach of using AsRef for type parameters in formatters that wrap other formatters. 2.0 is a good time to bring pre-existing formatters up to spec.
@sffc sffc added S-small Size: One afternoon (small bug fix or enhancement) 2.0-breaking Changes that are breaking API changes labels Jul 25, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Jul 25, 2024
@Manishearth Manishearth mentioned this issue Oct 17, 2024
Merged
@sffc sffc changed the title LocaleExpander and LocaleDirectionality should use AsRef for their type parameter LocaleCanonicalizer and LocaleDirectionality should use AsRef for their type parameter Oct 18, 2024
@sffc
Copy link
Member Author

sffc commented Oct 18, 2024

I realize I made a big typo in the title of this issue: we also need to fix LocaleCanonicalizer.

@Manishearth Manishearth reopened this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
2.0-breaking Changes that are breaking API changes S-small Size: One afternoon (small bug fix or enhancement)
Projects
icu4x 2.0
Status: Done
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

Successfully merging a pull request may close this issue.

Add AsRef<LocaleExpander> to LocaleDirectionality Manishearth/icu4x
2 participants
@sffc @Manishearth