Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move performance benchmark artifacts into /benchmark/perf instead of /dev #483

Closed
gregtatum opened this issue Feb 8, 2021 · 1 comment · Fixed by #546
Closed

Move performance benchmark artifacts into /benchmark/perf instead of /dev #483

gregtatum opened this issue Feb 8, 2021 · 1 comment · Fixed by #546
Assignees
@gregtatum
Labels
A-performance Area: Performance (CPU, Memory) C-test-infra Component: Integration test infrastructure T-techdebt Type: ICU4X code health and tech debt
Milestone
ICU4X 0.2

Comments

@gregtatum
Copy link
Member

This is a follow-up to #107. Now that there are multiple benchmarks, we should update the organization.

https://github.com/echeran/icu4x/blob/03b3486395ee1caa8970cc972c46c2ec40cd8ec7/.github/workflows/build-test.yml#L142
@gregtatum gregtatum added A-performance Area: Performance (CPU, Memory) T-techdebt Type: ICU4X code health and tech debt labels Feb 8, 2021
@gregtatum gregtatum changed the title Move performance benchmark artifacts into /benchmark/perf instead of /dev Move performance benchmark artifacts into /benchmark/perf instead of /dev Feb 8, 2021
@gregtatum gregtatum mentioned this issue Feb 8, 2021
Merged
@sffc sffc added this to the ICU4X 0.2 milestone Feb 12, 2021
@sffc sffc added the C-test-infra Component: Integration test infrastructure label Feb 12, 2021
@sffc sffc mentioned this issue Feb 12, 2021
Closed
@sffc
Copy link
Member

sffc commented Mar 12, 2021

Punt to post-0.2 cleanup (April)

@gregtatum gregtatum mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregtatum gregtatum

Labels
A-performance Area: Performance (CPU, Memory) C-test-infra Component: Integration test infrastructure T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
ICU4X 0.2
Development

Successfully merging a pull request may close this issue.

Re-organize the benchmark data gregtatum/icu4x
2 participants
@sffc @gregtatum