-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu::timezone
but icu::datetime::time_zone
#4350
Comments
We decided "Metazone" is one word but "Time Zone" is two words (#2507). This implies that it should be Options:
|
Discuss with: |
It doesn't look like we ever decided that "time zone" is two words, only that "metazone" is one. "timezone" seems to be the prevalent spelling: https://books.google.com/ngrams/graph?content=timezone%2C%22time+zone%22&year_start=1800&year_end=2000&case_insensitive=on&corpus=en-2012&smoothing=3 I vote for 4. |
CC @markusicu |
I maybe prefer option 3 just because TimeZone stylized with that casing is so common. But it means camel and snake don't agree which is unfortunate. |
No strong opinion. Not 4. |
My vote is for 3. Primarily because Temporal seems to set on |
Discussion:
Open for votes! |
My vote: option 2 -- change the module name to be consistent with the crate, but keep time_zone variables and TimeZone types |
I also vote 2 2 > 3 > 0 >> 4 > 1 |
2 > 3 > 4 >> 1,0 |
Ballots: https://docs.google.com/document/d/1cwObpQ_gdCsoZVEDNV7C-7eODxElGIJ3FNdivlbLnNo/edit Results: Options 0, 1, and 4 have vetoes. Among 2 and 3, option 2 is much more popular. It is also the first choice of 6 of 7 ballots. Therefore, option 2 wins. Action: find all modules in icu4x that have "time zone" in the name and make sure it is stylized as "timezone". |
The winning option 2 is the following style:
|
Names should be consistent
The text was updated successfully, but these errors were encountered: