-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixedDecimalFormatter and WeekCalculator should be conditionally loaded in datetime #4340
Comments
Bikeshed for the function name:
Opinion @zbraniecki @Manishearth @robertbastian ? |
3 > 2 > 1 >> 4 |
So what happens if you need a FDF but used this constructor? I like the |
It would have the same behavior as if you gave the DateTimePatternInterpolator a pattern that needs abbreviated month names but you didn't load abbreviated month names (returns a MissingDateNames error). |
3 > 1 > 2 >> 4 |
Zibi also suggested |
Ballots: https://docs.google.com/document/d/1cwObpQ_gdCsoZVEDNV7C-7eODxElGIJ3FNdivlbLnNo/edit Results: Option 3, |
Could possibly be done with field sets. |
I'm opening a PR where I do this for DateTimeNames. It's not immediately clear to me how to do this for field sets via the type system. I think I need the trait to optionally take a FixedDecimalFormatterLoader, but that is not currently public, and I've gotten pushback before when I tried to make the cross-crate loader stuff public. So, I would like to move the field set portion of this issue out of the 2.0 milestone. I propose putting it in Backlog. |
fine by me |
#4204 landed DateTimePatternInterpolator that always loads a FixedDecimalFormatter. Most patterns need one. However, not all patterns do, such as patterns that seek standalone display names. So should we make the FixedDecimalFormatter optional?
Maybe add a new constructor like
try_new_without_fixed_decimal_formatter
?The text was updated successfully, but these errors were encountered: