Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword "computationally heavy" language in docs #4237

Open
sffc opened this issue Oct 29, 2023 · 3 comments
Open

Reword "computationally heavy" language in docs #4237

sffc opened this issue Oct 29, 2023 · 3 comments
Assignees
Labels
C-datetime Component: datetime, calendars, time zones

Comments

@sffc
Copy link
Member

sffc commented Oct 29, 2023

Our docs have verbiage such as:

For that reason, one should think of the process of formatting a date in two steps - first, a computational heavy construction of DateTimeFormatter, and then fast formatting of DateTime data using the instance."

This is somewhat misleading. We should come up with better verbiage.

@sffc sffc added discuss Discuss at a future ICU4X-SC meeting C-datetime Component: datetime, calendars, time zones labels Oct 29, 2023
@zbraniecki
Copy link
Member

Do we have any measurements of the actual cost of DTF construction?

@sffc
Copy link
Member Author

sffc commented Oct 30, 2023

Let's block this on #3865 and write the verbiage based on measurements after those changes land.

@sffc sffc added blocked A dependency must be resolved before this is actionable and removed discuss Discuss at a future ICU4X-SC meeting labels Oct 30, 2023
@sffc sffc added this to the 1.4 Blocking ⟨P1⟩ milestone Oct 30, 2023
@sffc sffc modified the milestones: 1.5 Blocking ⟨P1⟩, ICU4X 2.0 May 23, 2024
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Sep 17, 2024
@Manishearth
Copy link
Member

Assigning to @sffc since it's a part of the whole set of datetime changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones
Projects
Status: Small breakage (defer to end)
Development

No branches or pull requests

3 participants