Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing for UnicodeSets #3556

Open
skius opened this issue Jun 21, 2023 · 1 comment
Open

Better testing for UnicodeSets #3556

skius opened this issue Jun 21, 2023 · 1 comment
Labels
C-unicode Component: Props, sets, tries

Comments

@skius
Copy link
Member

skius commented Jun 21, 2023

UnicodeSets should have more positive tests.

If conformance tests are create for UnicodeSets, we should add those too.

For now, ICU4C/ICU4J can be used as inspiration:

@skius skius added the C-unicode Component: Props, sets, tries label Jun 21, 2023
@skius skius self-assigned this Jun 21, 2023
@skius
Copy link
Member Author

skius commented Aug 29, 2023

More tests have been added since that PR, in particular in the spec-draft-compliance-PR #3670. They cover a good range of use cases.

What's still left is to decide whether we want conformance tests from upstream (which do not currently exist) before stabilizing this.

@skius skius removed their assignment Aug 29, 2023
@sffc sffc added the good first issue Good for newcomers label Oct 5, 2023
@sffc sffc added this to the Priority Backlog ⟨P3⟩ milestone Oct 5, 2023
@sffc sffc removed the good first issue Good for newcomers label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-unicode Component: Props, sets, tries
Projects
None yet
Development

No branches or pull requests

2 participants