Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deferring trie lookup for characters below U+0300 in the NFC iterator case #2385

Open
hsivonen opened this issue Aug 17, 2022 · 2 comments
Labels
A-performance Area: Performance (CPU, Memory) C-collator Component: Collation, normalization S-small Size: One afternoon (small bug fix or enhancement)

Comments

@hsivonen
Copy link
Member

#2378 optimizes away trie lookups when NFC passthrough succeeds. However, that's only with contiguous buffers. With the iterator formulation, characters that are equal or above decomposition_passthrough_bound but below composition_passthrough_bound could potentially avoid a trie lookup, but currently a trie lookup is made anyway.

Figure out if there's a reasonably-manageable way to defer the trie lookup in the iterator case.

@hsivonen hsivonen added A-performance Area: Performance (CPU, Memory) S-small Size: One afternoon (small bug fix or enhancement) C-collator Component: Collation, normalization labels Aug 17, 2022
@sffc
Copy link
Member

sffc commented Sep 8, 2022

@hsivonen What would be an appropriate milestone for this issue?

@hsivonen hsivonen added this to the ICU4X 1.2 milestone Sep 9, 2022
@hsivonen
Copy link
Member Author

hsivonen commented Sep 9, 2022

This isn't urgent, so it's kinda weird to assign a milestone. Since this doesn't need to be in 1.0 and not necessarily in next, either. I put 1.2 as the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-performance Area: Performance (CPU, Memory) C-collator Component: Collation, normalization S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants