Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new type like MinutesSinceEpoch to replace i32 in MetaZonePeriodV1 #2155

Open
samchen61661 opened this issue Jul 6, 2022 · 2 comments
Assignees
Labels
A-data Area: Data coverage or quality C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement) T-enhancement Type: Nice-to-have but not required

Comments

@samchen61661
Copy link
Member

The way to do this would be to make a new type like MinutesSinceEpoch, use it instead of i32 in the ZeroMap, and give it a custom Serialize and Deserialize impl.

Context:
Json file would be more readable, json file API can be customized.
Serialize as raw date timestamp in Json and deserialize as MinutesSinceEpoch.

@samchen61661 samchen61661 self-assigned this Jul 6, 2022
@sffc sffc added T-enhancement Type: Nice-to-have but not required C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement) A-data Area: Data coverage or quality labels Jul 30, 2022
@sffc sffc added this to the ICU4X 1.0 (Final) milestone Jul 30, 2022
@sffc
Copy link
Member

sffc commented Jul 30, 2022

@samchen61661 Feel free to work on this. If you can get it done by August 10 then we can most likely launch it in ICU4X 1.0.

@sffc
Copy link
Member

sffc commented Aug 9, 2022

Discussion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-data Area: Data coverage or quality C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement) T-enhancement Type: Nice-to-have but not required
Projects
None yet
Development

No branches or pull requests

2 participants