feat: constants should be constants

Author: kermanx

service/constants/constants.go

@@ -12,25 +12,22 @@ var version string
 // -X 'logic.appBaseUrl=http://uni-token.app'
 var appBaseUrl string
 
-func GetVersion() int {
-	if version == "" {
-		return 0
-	}
+var Version = func() int {
 	v, err := strconv.Atoi(version)
 	if err != nil {
 		return 0
 	}
 	return v
-}
+}()
 
-func GetAppBaseUrl() string {
+var AppBaseUrl = func() string {
 	if appBaseUrl == "" {
 		return "http://localhost:5173"
 	}
 	return appBaseUrl
-}
+}()
 
-func GetUserName() string {
+var UserName = func() string {
 	if userName := os.Getenv("UNI_TOKEN_SERVICE_USER"); userName != "" {
 		return userName
 	}
@@ -39,12 +36,12 @@ func GetUserName() string {
 		panic(err)
 	}
 	return currentUser.Username
-}
+}()
 
-func ShouldChangeUser() bool {
+var ShouldChangeUser = func() bool {
 	currentUser, err := user.Current()
 	if err != nil {
 		panic(err)
 	}
-	return currentUser.Username != GetUserName()
-}
+	return currentUser.Username != UserName
+}()

service/logic/open.go

@@ -7,7 +7,7 @@ import (
 	"time"
 
 	"uni-token-service/constants"
-	"uni-token-service/logic/open_browser"
+	openBrowser "uni-token-service/logic/open_browser"
 	"uni-token-service/store"
 
 	"github.com/google/uuid"
@@ -25,7 +25,7 @@ func OpenUI(params url.Values, auth bool) error {
 
 		var userName string
 		if len(allUsers) == 0 {
-			userName = constants.GetUserName()
+			userName = constants.UserName
 		} else {
 			userName = allUsers[0].Username
 		}
@@ -42,7 +42,7 @@ func OpenUI(params url.Values, auth bool) error {
 	params.Set("session", sessionId)
 	params.Set("port", strconv.Itoa(ServerPort))
 
-	err := openBrowser.OpenBrowser(constants.GetUserName(), constants.GetAppBaseUrl()+"?"+params.Encode())
+	err := openBrowser.OpenBrowser(constants.UserName, constants.AppBaseUrl+"?"+params.Encode())
 	if err != nil {
 		return err
 	}

service/logic/open_browser/linux.go

@@ -15,7 +15,7 @@ func OpenBrowser(targetUser string, url string) error {
 	for _, provider := range providers {
 		if _, err := exec.LookPath(provider); err == nil {
 			var cmd *exec.Cmd
-			if constants.ShouldChangeUser() {
+			if constants.ShouldChangeUser {
 				cmd = exec.Command("sudo", "-i", "-u", targetUser, provider, url)
 			} else {
 				cmd = exec.Command(provider, url)

service/main.go

@@ -69,7 +69,7 @@ func (p *program) Stop(s service.Service) error {
 }
 
 func main() {
-	username := constants.GetUserName()
+	username := constants.UserName
 	serviceName := serviceNamePrefix + "-" + url.PathEscape(username)
 
 	svcConfig := &service.Config{
@@ -112,7 +112,7 @@ func main() {
 	}
 
 	if command == "version" {
-		fmt.Printf("Service Version: %d\n", constants.GetVersion())
+		fmt.Println(constants.Version)
 		return
 	}
 
@@ -205,7 +205,7 @@ func handleSudo(useInstalled bool, args []string) {
 		&logic.SudoOptions{
 			Name: serviceDisplayName,
 			Env: map[string]string{
-				"UNI_TOKEN_SERVICE_USER": constants.GetUserName(),
+				"UNI_TOKEN_SERVICE_USER": constants.UserName,
 				"UNI_TOKEN_SERVICE_ROOT": discovery.GetServiceRootPath(),
 			},
 		},

service/server/action.go

@@ -19,7 +19,7 @@ func SetupActionAPI(router *gin.Engine) {
 func handleCheck(c *gin.Context) {
 	c.JSON(http.StatusOK, gin.H{
 		"__uni_token": true,
-		"version":     constants.GetVersion(),
+		"version":     constants.Version,
 	})
 }