Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unified] Use of /etc/chromium-flags.conf #254

Open
Eloston opened this issue Oct 25, 2021 · 2 comments
Open

[unified] Use of /etc/chromium-flags.conf #254

Eloston opened this issue Oct 25, 2021 · 2 comments

Comments

@Eloston
Copy link
Member

Eloston commented Oct 25, 2021

One thing that popped out to me on initial inspection of unified is chromium-flags.conf. Will this be overwritten on each package update? In regular Debian builds and unportable, we read files within /etc/chromium.d to avoid package updates from stomping over the user's changes.

@Eloston Eloston assigned ghost Oct 25, 2021
@ghost
Copy link

ghost commented Oct 25, 2021

It's because I switched to the launcher that we use over on Arch which just used a single file containing line terminated arguments to find arguments to append to chromium. I assumed dpkg / apt will automatically handle anything under /etc for backups. I only plan to change this file if there's some arguments we need to add by default. I'll test this later to see if it's actually an issue.

@Eloston
Copy link
Member Author

Eloston commented Oct 25, 2021

So apt in interactive mode (the default) will prompt the user what to do about the user-made modifications to package files. That's why Debian modifies packages to use .d directories so that packages can introduce new flags and users can add their own flags without causing a conflict at install time.

I personally have some flags to change the Chromium cache directory and enable Wayland. Also, it'd be a smoother transition from users transitioning from older versions of our packages or the official Chromium packages.

@Eloston Eloston changed the title Unified: Use of /etc/chromium-flags.conf [unified] Use of /etc/chromium-flags.conf Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant