From 75a1529e340c4a24dc244125a1ea8e55994bb4d4 Mon Sep 17 00:00:00 2001 From: Agnieszka Figiel Date: Fri, 6 Jan 2017 10:38:01 +0000 Subject: [PATCH] small amendments to error reporting --- app/workers/changes_history_generator_worker.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/workers/changes_history_generator_worker.rb b/app/workers/changes_history_generator_worker.rb index 498b60a147..e9979a63c5 100644 --- a/app/workers/changes_history_generator_worker.rb +++ b/app/workers/changes_history_generator_worker.rb @@ -8,8 +8,7 @@ def perform(aru_id, user_id) aru = Trade::AnnualReportUpload.find(aru_id) rescue ActiveRecord::RecordNotFound => e # catch this exception so that retry is not scheduled - message = "CITES Report #{aru_id} not found" - Rails.logger.warn message + Rails.logger.warn "CITES Report #{aru_id} not found" Appsignal.add_exception(e) if defined? Appsignal NotificationMailer.changelog_failed(user, aru).deliver end @@ -25,9 +24,10 @@ def perform(aru_id, user_id) obj.upload_file(tempfile.path) aru.update_attributes(aws_storage_path: obj.public_url) - rescue => e - Rails.logger.info("Something went wrong while uploading file to S3") - Rails.logger.info(e) + rescue Aws::S3::Errors::ServiceError => e + Rails.logger.warn "Something went wrong while uploading #{aru.id} to S3" + Rails.logger.warn e.class + Appsignal.add_exception(e) if defined? Appsignal end NotificationMailer.changelog(user, aru, tempfile).deliver