Skip to content

Commit d063e55

Browse files
committed
Fix typos and linguistic errors in documentation
Signed-off-by: Sebastien Dionne <survivant00@gmail.com>
1 parent 750bc62 commit d063e55

File tree

19 files changed

+23
-23
lines changed

19 files changed

+23
-23
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ PR reviewers will take into account the following aspects when reviewing your PR
4646
- code style: keep your code style consistent with the classes you are editing, such as variable names, ordering of methods, etc
4747
- scope of the fix: this is a very important factor. Sometimes, the fix should be applied to a broader range of classes, such as a bug that repeats itself in other parts of the code. Other times, the PR solves a bug only partially, because the bug has a broader impact than initially evaluated.
4848
- is the proposed fix the best approach for the Jira at hand?
49-
- backwards compatibility: we must prevent any PR that breaks compatibility with previous versions. If the PR| does so, it could still be okay, but this should be clearly documented it will probably be discussed by the project maintainers before being merged
49+
- backwards compatibility: we must prevent any PR that breaks compatibility with previous versions. If the PR does so, it could still be okay, but this should be clearly documented it will probably be discussed by the project maintainers before being merged
5050
- security impact: it is critical to evaluate if the PR has any sort of security impact, preventing the addition of exploitable flaws.
5151

5252
Your PR will be classified by the reviewer with one or more of the following labels: **bug fix**, **enhancement**, **new feature/API change**, and **dependency upgrade**.
@@ -82,7 +82,7 @@ Fork https://github.com/undertow-io/undertow into your GitHub account.
8282

8383
```bash
8484
git clone git@github.com:[your username]/undertow.git
85-
cd console
85+
cd undertow
8686
```
8787

8888
### Add a remote reference to upstream
@@ -209,7 +209,7 @@ It is a good practice to create a backup of your original branch in case you end
209209
reload your original fix (the GitHub remote origin account containing the PR can serve this purpose, as long as you don't
210210
overwrite it with a broken branch).
211211

212-
Once you are satisfied if your commits, run the tests again with `mvn clean verify`. Finally, check the changes your are going
212+
Once you are satisfied with your commits, run the tests again with `mvn clean verify`. Finally, check the changes you are going
213213
to push to origin are really okay with:
214214

215215
```bash

core/src/main/java/io/undertow/UndertowOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,13 +474,13 @@ public class UndertowOptions {
474474

475475

476476
/**
477-
* Configure a read timeout for a web socket, in milliseconds. If its present it will override {@link org.xnio.Options#READ_TIMEOUT}. If the given amount of time elapses without
477+
* Configure a read timeout for a web socket, in milliseconds. If it's present it will override {@link org.xnio.Options#READ_TIMEOUT}. If the given amount of time elapses without
478478
* a successful read taking place, the socket's next read will throw a {@link ReadTimeoutException}.
479479
*/
480480
public static final Option<Integer> WEB_SOCKETS_READ_TIMEOUT = Option.simple(Options.class, "WEB_SOCKETS_READ_TIMEOUT", Integer.class);
481481

482482
/**
483-
* Configure a write timeout for a web socket, in milliseconds. If its present it will override {@link org.xnio.Options#WRITE_TIMEOUT}. If the given amount of time elapses without
483+
* Configure a write timeout for a web socket, in milliseconds. If it's present it will override {@link org.xnio.Options#WRITE_TIMEOUT}. If the given amount of time elapses without
484484
* a successful write taking place, the socket's next write will throw a {@link WriteTimeoutException}.
485485
*/
486486
public static final Option<Integer> WEB_SOCKETS_WRITE_TIMEOUT = Option.simple(Options.class, "WEB_SOCKETS_WRITE_TIMEOUT", Integer.class);

core/src/main/java/io/undertow/protocols/http2/Http2PriorityTree.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public Http2PriorityTree() {
5252
}
5353

5454
/**
55-
* Resisters a stream, with its dependency and dependent information
55+
* Registers a stream, with its dependency and dependent information
5656
* @param streamId The stream id
5757
* @param dependency The stream this stream depends on, if no stream is specified this should be zero
5858
* @param weighting The weighting. If no weighting is specified this should be 16

core/src/main/java/io/undertow/security/handlers/CachedAuthenticatedSessionHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* {@link HttpHandler} responsible for setting up the {@link AuthenticatedSessionManager} for cached authentications and
3535
* registering a {@link NotificationReceiver} to receive the security notifications.
3636
* <p>
37-
* This handler also forces the session to change its session ID on sucessful authentication.
37+
* This handler also forces the session to change its session ID on successful authentication.
3838
*
3939
* @author <a href="mailto:darran.lofthouse@jboss.com">Darran Lofthouse</a>
4040
*/

core/src/main/java/io/undertow/server/handlers/builder/PredicatedHandlersParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ static Node parse(final String string, Deque<Token> tokens, boolean topLevel) {
361361
break;
362362
} else if(token.getToken().equals("\n") || token.getToken().equals(";")) {
363363
if(token.getToken().equals(";") && tokens.peek()!=null && tokens.peek().getToken().equals(ELSE)) {
364-
// something() -> predicate; ELSE predicate; - dont end processing since its followed by ELSE and its singular block
364+
// something() -> predicate; ELSE predicate; - don't end processing since it's followed by ELSE and it's singular block
365365
continue;
366366
} else if (token.getToken().equals("\n") && tokens.peek() != null && isOperator(tokens.peek().getToken())) {
367367
// predicate

core/src/main/java/io/undertow/server/handlers/cache/DirectBufferCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public class DirectBufferCache {
5353
*/
5454
public static final int MAX_AGE_NO_CACHING = 0;
5555
/**
56-
* Mage age -1, entries dont expire
56+
* Max age -1, entries don't expire
5757
*/
5858
public static final int MAX_AGE_NO_EXPIRY = -1;
5959

core/src/main/java/io/undertow/server/handlers/cache/LRUCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class LRUCache<K, V> {
4747
*/
4848
public static final int MAX_AGE_NO_CACHING = 0;
4949
/**
50-
* Mage age -1, entries dont expire
50+
* Max age -1, entries don't expire
5151
*/
5252
public static final int MAX_AGE_NO_EXPIRY = -1;
5353

core/src/main/java/io/undertow/server/handlers/resource/CachingResourceManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class CachingResourceManager implements ResourceManager {
3636
*/
3737
public static final int MAX_AGE_NO_CACHING = LRUCache.MAX_AGE_NO_CACHING;
3838
/**
39-
* Mage age -1, this force manager to retain entries until underlying resource manager indicate that entries expired/changed
39+
* Max age -1, this forces manager to retain entries until underlying resource manager indicates that entries expired/changed
4040
*/
4141
public static final int MAX_AGE_NO_EXPIRY = LRUCache.MAX_AGE_NO_EXPIRY;
4242
/**

core/src/main/java/io/undertow/server/handlers/sse/ServerSentEventConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ public <T> void addToAttachmentList(AttachmentKey<AttachmentList<T>> key, T valu
494494
public interface EventCallback {
495495

496496
/**
497-
* Notification that is called when a message is sucessfully sent
497+
* Notification that is called when a message is successfully sent
498498
*
499499
* @param connection The connection
500500
* @param data The message data

core/src/main/java/io/undertow/server/protocol/http2/Http2ReceiveListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
import static java.nio.charset.StandardCharsets.ISO_8859_1;
6767

6868
/**
69-
* The recieve listener for a Http2 connection.
69+
* The receive listener for a Http2 connection.
7070
* <p>
7171
* A new instance is created per connection.
7272
*

0 commit comments

Comments
 (0)