Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when running integration test #35

Open
rusheb opened this issue Feb 20, 2023 · 2 comments
Open

Fix warning when running integration test #35

rusheb opened this issue Feb 20, 2023 · 2 comments
Assignees
Labels
code-quality code quality improvement good first issue Good for newcomers

Comments

@rusheb
Copy link
Collaborator

rusheb commented Feb 20, 2023

The integration test produces the following warning:

tests/integration/test_train_model.py::test_train
/Users/rusheb/code/maze-transformer/venv/lib/python3.10/site-packages/torch/utils/data/dataloader.py:554: UserWarning: This DataLoader will create 16 worker processes in total. Our suggested max number of worker in current system is 8 (cpuset is not taken into account), which is smaller than what this DataLoader is going to create. Please be aware that excessive worker creation might get DataLoader running slow or even freeze, lower the worker number to avoid potential slowness/freeze if necessary.
warnings.warn(_create_warning_msg(

Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

We should fix it by reducing num_workers in the training config

@rusheb rusheb added the good first issue Good for newcomers label Feb 20, 2023
@cmathw cmathw self-assigned this Mar 17, 2023
@cmathw
Copy link
Contributor

cmathw commented Mar 20, 2023

Addressed in this PR: change num_workers #103 @rusheb Can I move this to done?

@rusheb
Copy link
Collaborator Author

rusheb commented Mar 21, 2023

Be my guest! Thanks for the fix!

@mivanit mivanit added the code-quality code quality improvement label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality code quality improvement good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants