Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log dataset_seq_length_summary to w&b summary #128

Open
rusheb opened this issue Mar 25, 2023 · 1 comment
Open

Don't log dataset_seq_length_summary to w&b summary #128

rusheb opened this issue Mar 25, 2023 · 1 comment
Labels
wandb anything related to weights & biases integration

Comments

@rusheb
Copy link
Collaborator

rusheb commented Mar 25, 2023

In get_dataloader in training.py we are adding dataset_seq_length_stats to the w&b summary which produces a lot of clutter.

We should just log this to the console and remove it from the summary.

The dataset_seq_length_stats_summary is also being logged twice

    logger.summary({"dataset_seq_len_stats_summary": length_stats.summary()})
    logger.summary(
        {"dataset_seq_len_stats": length_stats.serialize(typecast=lambda x: str(x))}
    )

this is because the call to lengh_stats.serialize also includes the summary. We should remove the redundant first line.

@traeuker
Copy link
Member

Seems to not happen anymore in the code; unsure, low-confidence, likely wrong, but also probably worth simply de-prioing

@mivanit mivanit added the wandb anything related to weights & biases integration label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wandb anything related to weights & biases integration
Projects
None yet
Development

No branches or pull requests

3 participants