Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[import-x/no-duplicates] performance is bad #103

Closed
tjx666 opened this issue Jul 2, 2024 · 3 comments · Fixed by #104
Closed

[import-x/no-duplicates] performance is bad #103

tjx666 opened this issue Jul 2, 2024 · 3 comments · Fixed by #104

Comments

@tjx666
Copy link

tjx666 commented Jul 2, 2024

In most of the files I test, the performance of rule import-x/no-duplicates is most bad:

image

test command:

TIMING=1 eslint /path/to/lint.tsx
@macalinao
Copy link

Having the same issue

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 6, 2024

This is expected. no-duplicates was ported directly from eslint-plugin-import and the code by the time is a messy sh*t. I will rewrite this rule to be more performant.

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 6, 2024

The issue should be resolved and will be released in the next version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants