diff --git a/.changeset/bright-taxis-smell.md b/.changeset/bright-taxis-smell.md new file mode 100644 index 000000000..be8ed24ef --- /dev/null +++ b/.changeset/bright-taxis-smell.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-import-x": minor +--- + +Allow incorrect file path in extraneous deps check diff --git a/src/rules/no-extraneous-dependencies.ts b/src/rules/no-extraneous-dependencies.ts index 9d9c167cb..f91324bae 100644 --- a/src/rules/no-extraneous-dependencies.ts +++ b/src/rules/no-extraneous-dependencies.ts @@ -55,8 +55,11 @@ function extractDepFields(pkg: PackageJson) { function getPackageDepFields(packageJsonPath: string, throwAtRead: boolean) { if (!depFieldCache.has(packageJsonPath)) { - const depFields = extractDepFields(readJSON(packageJsonPath, throwAtRead)!) - depFieldCache.set(packageJsonPath, depFields) + const packageJson = readJSON(packageJsonPath, throwAtRead) + if (packageJson) { + const depFields = extractDepFields(packageJson) + depFieldCache.set(packageJsonPath, depFields) + } } return depFieldCache.get(packageJsonPath) } @@ -83,10 +86,15 @@ function getDependencies(context: RuleContext, packageDir?: string | string[]) { // use rule config to find package.json for (const dir of paths) { const packageJsonPath = path.resolve(dir, 'package.json') - const packageContent_ = getPackageDepFields(packageJsonPath, true)! - for (const depsKey of Object.keys(packageContent)) { - const key = depsKey as keyof PackageDeps - Object.assign(packageContent[key], packageContent_[key]) + const packageContent_ = getPackageDepFields( + packageJsonPath, + paths.length === 1, + ) + if (packageContent_) { + for (const depsKey of Object.keys(packageContent)) { + const key = depsKey as keyof PackageDeps + Object.assign(packageContent[key], packageContent_[key]) + } } } } else { diff --git a/test/rules/no-extraneous-dependencies.spec.ts b/test/rules/no-extraneous-dependencies.spec.ts index 98299b487..610005b9a 100644 --- a/test/rules/no-extraneous-dependencies.spec.ts +++ b/test/rules/no-extraneous-dependencies.spec.ts @@ -48,6 +48,7 @@ const packageDirBundledDepsAsObject = testFilePath( const packageDirBundledDepsRaceCondition = testFilePath( 'bundled-dependencies/race-condition', ) +const emptyPackageDir = testFilePath('empty-folder') ruleTester.run('no-extraneous-dependencies', rule, { valid: [ @@ -130,6 +131,14 @@ ruleTester.run('no-extraneous-dependencies', rule, { code: 'import leftpad from "left-pad";', options: [{ packageDir: packageDirMonoRepoRoot }], }), + test({ + code: 'import leftpad from "left-pad";', + options: [{ packageDir: [emptyPackageDir, packageDirMonoRepoRoot] }], + }), + test({ + code: 'import leftpad from "left-pad";', + options: [{ packageDir: [packageDirMonoRepoRoot, emptyPackageDir] }], + }), test({ code: 'import react from "react";', options: [