Merge pull request #1 from umulmrum/scrutinizer

Add Scrutinizer.

Author: umulmrum

.scrutinizer.yml

@@ -0,0 +1,23 @@
+build:
+    tests:
+        override:
+            -
+                command: 'vendor/bin/phpunit --coverage-clover=clover.xml'
+                coverage:
+                    file: 'clover.xml'
+                    format: 'clover'
+
+checks:
+    php:
+        code_rating: true
+        duplication: true
+
+coding_style:
+    php:
+        spaces:
+            around_operators:
+                concatenation: true
+
+filter:
+    excluded_paths:
+        - 'tests/*'

.travis.yml

@@ -21,7 +21,3 @@ before_install:
 install:
   - if [[ "$DEPENDENCIES" = 'high' ]]; then travis_retry composer update $DEFAULT_COMPOSER_FLAGS; fi
   - if [[ "$DEPENDENCIES" = 'low' ]]; then travis_retry composer update $DEFAULT_COMPOSER_FLAGS --prefer-lowest; fi
-
-script:
-  - phpunit
-  - php coverage-checker.php clover.xml 90

coverage-checker.php

@@ -16,13 +16,4 @@
             <directory>tests/</directory>
         </testsuite>
     </testsuites>
-
-    <filter>
-        <whitelist addUncoveredFilesFromWhitelist="true">
-            <directory suffix=".php">./src</directory>
-        </whitelist>
-    </filter>
-    <logging>
-        <log type="coverage-clover" target="./clover.xml"/>
-    </logging>
 </phpunit>

phpunit.xml.dist

@@ -92,8 +92,6 @@ public function generate(): \Generator
         } finally {
             $this->dataSource->finish();
         }
-
-        return null;
     }
 
     /**

src/JsonParser.php

@@ -27,6 +27,7 @@ public function run(DataSourceInterface $dataSource)
                     }
 
                     InvalidJsonException::trigger('No value found for key', $dataSource);
+                    // no break
                 case '"':
                     if (null !== $currentKey) {
                         InvalidJsonException::trigger('Invalid character \'"\', ":" expected', $dataSource);

src/State/RootObjectState.php

@@ -3,9 +3,7 @@
 namespace umulmrum\JsonParser\Test\DataSource;
 
 use PHPUnit\Framework\TestCase;
-use umulmrum\JsonParser\DataSource\DataSourceException;
 use umulmrum\JsonParser\DataSource\FileDataSource;
-use umulmrum\JsonParser\InvalidJsonException;
 
 class FileDataSourceTest extends TestCase
 {

tests/DataSource/FileDataSourceTest.php

@@ -61,7 +61,7 @@ public function testAllValid(string $fileToCheck): void
 
     public function provideDataForTestAllValid(): array
     {
-        return $this->getTestCasesFromPath(__DIR__ . '/fixtures/valid');
+        return $this->getTestCasesFromPath(__DIR__.'/fixtures/valid');
     }
 
     private function getTestCasesFromPath(string $path): array
@@ -74,7 +74,7 @@ private function getTestCasesFromPath(string $path): array
                 continue;
             }
 
-            $files[] = [ $entry ];
+            $files[] = [$entry];
         }
 
         \closedir($dir);
@@ -121,7 +121,7 @@ public function testAllInvalid(string $fileToCheck): void
 
     public function provideDataForTestAllInvalid(): array
     {
-        return $this->getTestCasesFromPath(__DIR__ . '/fixtures/invalid');
+        return $this->getTestCasesFromPath(__DIR__.'/fixtures/invalid');
     }
 
     private function givenADataSourceForInvalidFiles(string $fileToCheck): void
@@ -287,8 +287,8 @@ private function whenGenerateIsCalledUntilTheDataSourceIsDepleted(): void
      * @dataProvider provideDataForTestErrorInfo
      *
      * @param string $fileToCheck
-     * @param int $expectedErrorLine
-     * @param int $expectedErrorColumn
+     * @param int    $expectedErrorLine
+     * @param int    $expectedErrorColumn
      */
     public function testErrorInfo(string $fileToCheck, int $expectedErrorLine, int $expectedErrorColumn): void
     {