unpin bugfix js version, use codecov github action

umputun · Nov 8, 2024 · c1a447b · c1a447b
1 parent 3c110eb
commit c1a447b
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 105 deletions.
diff --git a/.github/workflows/ci-frontend-api.yml b/.github/workflows/ci-frontend-api.yml
@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [ 16 ]
 
     steps:
       - name: Checkout
@@ -64,7 +64,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [ 16 ]
 
     steps:
       - name: Checkout
@@ -108,7 +108,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [ 16 ]
 
     steps:
       - name: Checkout
@@ -147,7 +147,9 @@ jobs:
         run: pnpm coverage:api
         working-directory: ./frontend
 
-      - name: Submit coverage
-        run: ${{ github.workspace }}/frontend/apps/remark42/node_modules/.bin/codecov
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          working-directory: ./frontend
+          codecov_yml_path: ./frontend/apps/remark42/codecov.yml
diff --git a/.github/workflows/ci-frontend.yml b/.github/workflows/ci-frontend.yml
@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [16]
 
     steps:
       - name: Checkout
@@ -64,7 +64,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [16]
 
     steps:
       - name: Checkout
@@ -108,7 +108,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [16]
 
     steps:
       - name: Checkout
@@ -176,7 +176,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16.20.2]
+        node: [16]
 
     steps:
       - name: Checkout
@@ -215,7 +215,9 @@ jobs:
         run: pnpm coverage
         working-directory: ./frontend/apps/remark42
 
-      - name: Submit coverage
-        run: ${{ github.workspace }}/frontend/apps/remark42/node_modules/.bin/codecov
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          working-directory: ./frontend/apps/remark42
+          codecov_yml_path: ./frontend/apps/remark42/codecov.yml
diff --git a/Dockerfile.artifacts b/Dockerfile.artifacts
@@ -1,4 +1,4 @@
-FROM node:16.20.2-alpine AS frontend-deps
+FROM node:16-alpine AS frontend-deps
 
 ENV CI=true
 

diff --git a/frontend/.nvmrc b/frontend/.nvmrc
@@ -1 +1 @@
-16.20.2
+16
diff --git a/frontend/apps/remark42/codecov.yml b/frontend/apps/remark42/codecov.yml
@@ -1,6 +1,5 @@
 codecov:
-  notify:
-    require_ci_to_pass: false
+  require_ci_to_pass: false
 
 ignore:
   - .editorconfig

diff --git a/frontend/apps/remark42/package.json b/frontend/apps/remark42/package.json
@@ -75,7 +75,6 @@
     "babel-loader": "^8.2.5",
     "babel-plugin-jsx-remove-data-test-id": "^3.0.0",
     "clean-webpack-plugin": "^4.0.0",
-    "codecov": "^3.8.3",
     "copy-webpack-plugin": "^12.0.2",
     "cross-env": "^7.0.3",
     "css-loader": "^6.7.1",

diff --git a/frontend/pnpm-lock.yaml b/frontend/pnpm-lock.yaml