Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate to per "type" packages #4

Open
jelen07 opened this issue Apr 4, 2020 · 7 comments
Open

Separate to per "type" packages #4

jelen07 opened this issue Apr 4, 2020 · 7 comments

Comments

@jelen07
Copy link

jelen07 commented Apr 4, 2020

Is there any plan to separate this package "type" specific packages? Like

  • locale-list-yaml
  • locale-list-csv
  • ...

The whole repository has ~179MB. When building an image with ~40MB, app ~10MB this is so much overhead.

@umpirsky
Copy link
Owner

umpirsky commented Apr 4, 2020

What kind of "image" are you building?

@jelen07
Copy link
Author

jelen07 commented Apr 6, 2020

Oh, I'm sorry - docker image with the application that depends on this package.

@umpirsky
Copy link
Owner

umpirsky commented Apr 6, 2020

I didn't plan to, I always assumed disk is cheap.

But you can easily create composer post install script that cleans up what you don't need.

@jelen07
Copy link
Author

jelen07 commented Apr 6, 2020

Yes, it's cheap. But when you have more than 100 projects, which exists in x version (due to potential deployment rollback) you are trying to keep the vendor size as small as possible.
In the example above we're talking about more than 15 GB which must be hosted/transferred because of one library.
We could remove the files via post-install script, . dockerignore (edited) or some other method but that means that we will be solving problem on a different level than the problem really is.
I think that the fork will be the most suitable.

@umpirsky
Copy link
Owner

umpirsky commented Apr 6, 2020

I don't think .gitignore will help. Post install script sounds reasonable. If you go for the fork, you need to maintain it yourself.

@jelen07
Copy link
Author

jelen07 commented Apr 6, 2020

Sorry, I wanted to write ".dockerignore".
Adding a post-install script means adding extra complexity to the project. In the case of a fork, there is extra maintenance work that should be done to keep things up to date. But the project is cleaner.

@umpirsky
Copy link
Owner

umpirsky commented Apr 6, 2020

I still think post-install script is your best option, but whatever works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants