Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add self sg ingress rule option #7

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Add self sg ingress rule option #7

merged 1 commit into from
Nov 9, 2020

Conversation

bogdanbarna
Copy link
Contributor

Description

Similar to the ingress_cidr_blocks, this allows users to configure the Redis security group to only allow access from itself.

marcincuber
marcincuber suggested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@marcincuber marcincuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Some comments to be resolved before we can merge this.

@bogdanbarna
Copy link
Contributor Author

Thanks for your contribution.
Some comments to be resolved before we can merge this.

Thank you for looking at this.
I've amended my commit according to your input.

@marcincuber marcincuber merged commit 5803b28 into umotif-public:master Nov 9, 2020
@marcincuber
Copy link
Contributor

This is now available with version 1.2.0 of this module.

@bogdanbarna bogdanbarna deleted the add-sg-self-ingress branch November 9, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcincuber marcincuber marcincuber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdanbarna @marcincuber