Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade module to be compatible with AWS Provider 4.0.0 #21

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Upgrade module to be compatible with AWS Provider 4.0.0 #21

merged 1 commit into from
Mar 9, 2022

Conversation

Ohid25
Copy link
Contributor

@Ohid25 Ohid25 commented Mar 9, 2022

Description

BREAKING CHANGES

  1. Removed cluster_mode to use replicas_per_node_group and num_node_groups directly.
  2. number_cache_clusters changed to use num_cache_clusters
  3. availability_zones changed to use preferred_cache_cluster_azs
  4. replication_group_description changed to use description

You will still need to set cluster_mode_enabled to true if you want a Redis cluster.

These changes are based on the deprecation warnings that are received when trying to use this module with provider >=4.0.0

@Ohid25 Ohid25 requested a review from a team March 9, 2022 13:12
@Ohid25 Ohid25 mentioned this pull request Mar 9, 2022
Closed
@Ohid25 Ohid25 requested a review from Mohammed-afk91 March 9, 2022 14:04
@Ohid25 Ohid25 merged commit 67cf19b into main Mar 9, 2022
@Ohid25 Ohid25 deleted the feature/4.0 branch March 9, 2022 14:09
@Ohid25
Copy link
Contributor Author

Ohid25 commented Mar 9, 2022 •
edited
Loading

Released as 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohammed-afk91 Mohammed-afk91 Mohammed-afk91 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ohid25 @Mohammed-afk91