Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin-layout #23

Merged
merged 2 commits into from
Feb 13, 2020
Merged

feat: plugin-layout #23

merged 2 commits into from
Feb 13, 2020

Conversation

Ariel-Cheng
Copy link
Contributor

  • 迁移 @umijs/plugin-layout

Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要找个 example 跑通流程
  2. merge 下 master 的代码,之前的 yarn.lock 有问题

packages/plugin-layout/package.json Outdated Show resolved Hide resolved
packages/plugin-layout/package.json Outdated Show resolved Hide resolved
packages/plugin-layout/package.json Outdated Show resolved Hide resolved
packages/plugin-layout/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-layout/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-layout/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-layout/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-layout/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-layout/src/layout/index.tsx Outdated Show resolved Hide resolved
@Ariel-Cheng Ariel-Cheng force-pushed the feat/plugin-layout branch 4 times, most recently from 16e493c to 62cf9c4 Compare February 12, 2020 14:00
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #23 into master will decrease coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   44.08%   42.09%   -1.99%     
==========================================
  Files          23       32       +9     
  Lines         431      639     +208     
  Branches       93      174      +81     
==========================================
+ Hits          190      269      +79     
- Misses        240      370     +130     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
packages/plugin-model/src/utils/index.ts 0.00% <0.00%> (ø) ⬆️
...lugin-layout/src/component/ErrorBoundary/index.tsx 0.00% <0.00%> (ø)
packages/plugin-layout/src/layout/index.tsx 0.00% <0.00%> (ø)
packages/plugin-layout/src/utils/intl.ts 0.00% <0.00%> (ø)
...lugin-layout/src/utils/getLayoutConfigFromRoute.ts 88.37% <0.00%> (ø)
...ckages/plugin-layout/src/utils/getMenuFromRoute.ts 90.90% <0.00%> (ø)
packages/plugin-layout/src/index.ts 0.00% <0.00%> (ø)
...es/plugin-layout/src/component/Exception/index.tsx 0.00% <0.00%> (ø)
...kages/plugin-layout/src/utils/getLayoutContent.tsx 100.00% <0.00%> (ø)
...kages/plugin-layout/src/layout/useRightContent.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba0c52...afef919. Read the comment docs.

@sorrycc
Copy link
Member

sorrycc commented Feb 13, 2020

提交不要 force push,看不了 diff。

@sorrycc
Copy link
Member

sorrycc commented Feb 13, 2020

先 merge 了,有需要后面再改吧。

@sorrycc sorrycc merged commit ef66fdc into master Feb 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/plugin-layout branch February 13, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants