Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chome version to 2.43 #7

Closed
xoxwgys56 opened this issue Jun 9, 2021 · 3 comments
Closed

Upgrade chome version to 2.43 #7

xoxwgys56 opened this issue Jun 9, 2021 · 3 comments

Comments

@xoxwgys56
Copy link

Hey @umihico I must say this repository is so great. It is so helpful for me.

But I have a question for about Dockerfile. You use chrome version 2.37.
It looks like so old thing there is release note about this version. so I thought there is reason why you use this version.

If not, I suggest higher version of chrome which duolabmeng6 said in this issue. I think version 86.0 takes more memory like duolabmeng6 said so version 2.43 is more stable for lambda.


Additional attachment

only changed chrome version.

FROM public.ecr.aws/lambda/python:3.8 as build
RUN yum install -y unzip && \
    curl -SL https://chromedriver.storage.googleapis.com/2.43/chromedriver_linux64.zip > /tmp/chromedriver.zip && \
    curl -SL https://github.com/adieuadieu/serverless-chrome/releases/download/v1.0.0-55/stable-headless-chromium-amazonlinux-2017-03.zip > /tmp/headless-chromium.zip && \
    unzip /tmp/chromedriver.zip -d /opt/ && \
    unzip /tmp/headless-chromium.zip -d /opt/

FROM public.ecr.aws/lambda/python:3.8
RUN yum install -y https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm
RUN pip install selenium
COPY --from=build /opt/headless-chromium /opt/
COPY --from=build /opt/chromedriver /opt/
COPY test.py ./
CMD [ "test.handler" ]
@umihico
Copy link
Owner

umihico commented Jun 9, 2021

@xoxwgys56
Thank you for your report. I also confirmed that 2.43 with v1.0.0-55 works well. I don't have any specific reasons to keep using 2.37. It was just the latest version which I know works.

Could you give me a pull request? I'd like to add your name as a contributer.

@xoxwgys56
Copy link
Author

xoxwgys56 commented Jun 9, 2021

@umihico Oh it is so pleasure to me become a contributor on your repository.
Okay I make a pull request.

  • also follow existed branch name convention

@xoxwgys56
Copy link
Author

Created pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants