tRFCb
is not applied for BANK_LEVEL_STAGGERED
refresh policy #24
Open
Description
It seems like tRFCb
for BANK_LEVEL_STAGGERED
refresh policy is not applied. Timing parameters for it are defined at timing.cc:225, but the one of them, same_rank
, is not used at UpdateTiming() in channel_state.cc.
In my opinion, the same_rank
at timing.cc:225 should be same_bank
. Please confirm it.
Example
- Config:
configs/DDR4_8Gb_x8_3200.ini
withBANK_LEVEL_STAGGERED
as refresh policy. (tRFCb
= 20) - Trace
0x20000000 READ 1950
- Command trace (vanilla version)
1950 refresh_bank -1 0 0 0 -0x1 -0x1 1952 activate 0 0 0 0 0x800 0x0 ## it should be issued at 1970 (= 1950 + 20) 1974 read 0 0 0 0 0x800 0x0
- Command trace (modifying
same_bank
tosame_rank
)1950 refresh_bank -1 0 0 0 -0x1 -0x1 1970 activate 0 0 0 0 0x800 0x0 1992 read 0 0 0 0 0x800 0x0
Metadata
Assignees
Labels
No labels