Skip to content

fix(uui-tab-group): async tabs are not calculated correctly and have memory leaks #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 2, 2024

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Feb 1, 2024

Fixes memory leaks and layout issues in tab group.
Added support for async tabs, including async layout changes inside a tab.
Added stories to demonstrate flex layouts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

github-actions bot commented Feb 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-726.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Feb 2, 2024
@iOvergaard iOvergaard changed the title V1/bugfix/tab group fix(uui-tab-group): async tabs are not calculated correctly and have memory leaks Feb 2, 2024
@iOvergaard iOvergaard enabled auto-merge (squash) February 2, 2024 11:20
Copy link

github-actions bot commented Feb 2, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-726.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit 03c5cdc into v1/contrib Feb 2, 2024
@iOvergaard iOvergaard deleted the v1/bugfix/tab-group branch February 2, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants