Skip to content

set display to block on uui-tab-group #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2024
Merged

set display to block on uui-tab-group #722

merged 1 commit into from
Jan 26, 2024

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Jan 26, 2024

Description

The element, like any custom element defaults to inline. Tab group should be a block element.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-722.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Jan 26, 2024
@iOvergaard iOvergaard merged commit ac5c2b1 into v1/contrib Jan 26, 2024
@iOvergaard iOvergaard deleted the set-display-to-block-on-uui-tab-group branch January 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julczka @iOvergaard