Toggle color picker popover clicking preview button #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This move the preview button (when not inline color picker) inside
<uui-popover>
as the example here: https://uui.umbraco.com/?path=/docs/uui-popover--docsThis change also make it toggle the color picker when clicking the preview button, where it currently only opens.
I think the
<uui-popover>
need some changes, so it close when clicking the container as well, but not when clicking inside<div slot="popover">
(the actual popover).In the example and this with color picker, there's an area next to the button, where clicking this doesn't close - it looks like outside the popover click, but is actually inside
<uui-popover>
.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
chrome_4OTuce8FF5.mp4
Checklist