Skip to content

Feature/range slider update #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 17, 2023
Merged

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Sep 8, 2023

Description

Range slider update

Types of changes

Fixes #562
Fixes #545

A lot of the logic of the range slider has been updated and reworked. This update makes the range slider rely more on the native inputs, which should cause the range slider to perform better with a lot fewer calculations needed.

Breaking change: valueLow and valueHigh properties have been removed. Use the value property instead. The value property is a string with the low-end value followed by a comma and then the high-end value. For example, setting the value to "-575,900" will result in a low-end value of -575 and a high-end value of 900.

If the value is not set, the value will default to the min and max values set.

Previously the range slider would check and attempt to validate all property values every time a change was made.
In this update, when the range slider is first rendered, the range slider will perform some checks to see if the properties set makes any sense. For example, setting a min-gap that is larger than a max-gap will result in the gaps being removed followed by a console warning of the changes made.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

The previous range slider had some bugs which made it unusable in certain situations. A performance boost has been very needed as well.

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@loivsen loivsen linked an issue Sep 11, 2023 that may be closed by this pull request
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@loivsen loivsen linked an issue Oct 16, 2023 that may be closed by this pull request
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

loivsen and others added 3 commits October 17, 2023 13:35
…lider-update

# Conflicts:
#	packages/uui-color-picker/lib/uui-color-picker.element.ts
#	packages/uui-range-slider/lib/uui-range-slider.element.ts
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good :-)

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) October 17, 2023 14:55
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 0dcf0a2 into v1/contrib Oct 17, 2023
@nielslyngsoe nielslyngsoe deleted the feature/range-slider-update branch October 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range Slider interaction fields intercept unexpected Range Slider renders incorrectly
2 participants