-
Notifications
You must be signed in to change notification settings - Fork 53
Feature/range slider update #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
…lider-update # Conflicts: # packages/uui-color-picker/lib/uui-color-picker.element.ts # packages/uui-range-slider/lib/uui-range-slider.element.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good :-)
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-569.westeurope.azurestaticapps.net |
Description
Range slider update
Types of changes
Fixes #562
Fixes #545
A lot of the logic of the range slider has been updated and reworked. This update makes the range slider rely more on the native inputs, which should cause the range slider to perform better with a lot fewer calculations needed.
Breaking change: valueLow and valueHigh properties have been removed. Use the value property instead. The value property is a string with the low-end value followed by a comma and then the high-end value. For example, setting the value to "-575,900" will result in a low-end value of -575 and a high-end value of 900.
If the value is not set, the value will default to the min and max values set.
Previously the range slider would check and attempt to validate all property values every time a change was made.
In this update, when the range slider is first rendered, the range slider will perform some checks to see if the properties set makes any sense. For example, setting a min-gap that is larger than a max-gap will result in the gaps being removed followed by a console warning of the changes made.
Motivation and context
The previous range slider had some bugs which made it unusable in certain situations. A performance boost has been very needed as well.