-
Notifications
You must be signed in to change notification settings - Fork 53
Feature: uui-divider
component
#1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a new uui-divider component to the project.
- Introduces the divider component files (element, tests, stories, etc.).
- Updates the main index exports and project configuration files to incorporate the new component.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/uui/lib/index.ts | Added export for the uui-divider package |
packages/uui-divider/tsconfig.json | Created TS configuration for the divider component |
packages/uui-divider/rollup.config.js | Configured rollup for uui-divider package |
packages/uui-divider/package.json | Defined package details and dependencies |
packages/uui-divider/lib/uui-divider.test.ts | Added tests for the divider component |
packages/uui-divider/lib/uui-divider.story.ts | Added storybook stories for the divider component |
packages/uui-divider/lib/uui-divider.element.ts | Implemented the divider component with customizable props |
packages/uui-divider/lib/index.ts | Set up component export |
packages/uui-divider/README.md | Documented component installation and usage |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Description
Added a new
uui-divider
component similar to this: https://shoelace.style/components/divider/I think it may to useful to separate content, menu items etc.
It can possible also replace divider here in CMS (unless we want a separate component for this or split panel like this: https://shoelace.style/components/split-panel/ )
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist