Skip to content

Commit b69ed74

Browse files
committed
fix(uui-select): move 'height' and other properties to inner element because it is easiest to control the select rather than mimick it in terms of :focus and :hover on the outer element
1 parent 174c6c5 commit b69ed74

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

packages/uui-select/lib/uui-select.element.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -248,28 +248,26 @@ export class UUISelectElement extends FormControlMixin(LitElement) {
248248
display: inline-block;
249249
position: relative;
250250
font-family: inherit;
251-
height: var(--uui-select-height, var(--uui-size-11));
252251
}
253252
254253
#native {
255254
display: inline-block;
256255
font-family: inherit;
257256
font-size: var(--uui-select-font-size, var(--uui-size-5));
258-
height: inherit;
259-
width: 100%;
257+
height: var(--uui-select-height, var(--uui-size-11));
260258
padding: var(--uui-select-padding-y, var(--uui-size-1))
261259
var(--uui-select-padding-x, var(--uui-size-2));
262260
color: currentColor;
263-
border-radius: 0;
264261
box-sizing: border-box;
262+
border-radius: 0;
265263
border: 1px solid
266264
var(--uui-select-border-color, var(--uui-color-border));
267265
transition: all 150ms ease;
268266
}
269267
270268
#native:focus {
271269
outline: calc(2px * var(--uui-show-focus-outline, 1)) solid
272-
var(--uui-color-focus);
270+
var(--uui-select-outline-color, var(--uui-color-focus));
273271
}
274272
275273
#native[disabled] {
@@ -296,11 +294,6 @@ export class UUISelectElement extends FormControlMixin(LitElement) {
296294
);
297295
}
298296
299-
/* TODO: a proper focus style has to be implemented. it needs it's own variables */
300-
#native:focus {
301-
outline-color: var(--uui-select-outline-color, var(--uui-color-focus));
302-
}
303-
304297
#caret {
305298
position: absolute;
306299
right: 12px;

0 commit comments

Comments
 (0)