Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V11 content not updated for use of block grid #114

Open
AndyButland opened this issue Dec 7, 2022 · 0 comments
Open

V11 content not updated for use of block grid #114

AndyButland opened this issue Dec 7, 2022 · 0 comments

Comments

@AndyButland
Copy link
Contributor

I was looking into an issue reported for Deploy using the new block grid. It was being triggered by receiving unexpected JSON content when transferring content containing the new block grid.

I believe this is happening because the default content installed - from the XML file within package.zip file - still has some content for an empty grid based on the legacy grid editor.

E.g.:

<bodyText><![CDATA[{"name":"1 column layout","sections":[{"grid":"12","rows":[]}]}]]></bodyText>

We can - and should - fix it in the Deploy connector such that we are more defensive against bad input. But probably this should be updated too.

The problem goes away if you first save the content, which makes sure that a correctly empty block grid value is saved. If I then export the package I can see the fields are omitted.

So I think it's just a case of going through the package.xml file and removing these elements that represent empty grid content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant