Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider adding SkipList option #185

Open
vkuznet opened this issue Mar 25, 2022 · 1 comment
Open

Please consider adding SkipList option #185

vkuznet opened this issue Mar 25, 2022 · 1 comment

Comments

@vkuznet
Copy link

vkuznet commented Mar 25, 2022

Hi, this is a very nice of software we'd like to use in our stack but it lacks of SkipList option which is very useful to allow certain clients to bypass limiter functionality. Would you be willing to consider to add this functionality? I need to stress out that in combination of custom HTTP header to use it will significantly increase its usage. For instance, the limiter can be applied to a custom HTTP header which identifies user, e.g. at CERN we use user's X509 DN. As such we can apply this to GRID jobs and limit users (abuser) based on their DN. But for production services we want to avoid that and can put their DNs in skip list if it will be provided.

@vkuznet
Copy link
Author

vkuznet commented Mar 25, 2022

I provided a prototype of changes in this PR #186. I'm open to any implementations and only would like to stress out that such addition would be very useful for our use case.

@vkuznet vkuznet changed the title Please consider adding WhilteList option Please consider adding SkipList option Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant