laytout:title-pattern doesn't include dynamic page titles

[adnansorg]

In my content page content.html with the layout set to layout.html I have a title such as:

<title th:text="${user.name}"></title>

In the layout.html, the title pattern is used as following.

<title layout:title-pattern="$DECORATOR_TITLE - $CONTENT_TITLE">Website Name</title>

When using a normal static<title>User Details</title> without th:text the decorator correctly applies the title pattern as <title>Website Name - User Details</title> while the title with the dynamic th:text tag decorates the title as <title>User Details</title>

Am I doing this correct or is layout:title-pattern only able to apply to static title names?

[ultraq]

I thought it applied to dynamic titles as I have a dynamic title on a site that uses layout:title-pattern, but it looks like that dynamic title is working because it takes a different approach of using th:inline and then an inline text expression on <title>.

So you can use the inline text approach as a workaround for now, but layout:title-pattern really should work for dynamic titles constructed with th:text, so I'll add this to the todo list for the next release.

[adnansorg]

th:inline="text" works perfectly with this. Thanks for the tip.

[ultraq]

I've updated the decoration process so that layout:title-pattern will include text/expressions in th:text attributes in the <title> element. I've also uploaded a new 1.2-SNAPSHOT of the layout dialect that will have this fix.

For anybody reading this, I couldn't port the fix to the 1.1 branch of the layout dialect (I'm planning to make just 1 more release for 1.1 for Thymeleaf 2.0 which has just some refactoring goodies I did as part of the work to make this Thymeleaf 2.1 compatible) as the fix uses the new literal substitutions feature of Thymeleaf 2.1.

[chrylis]

I hit this bug and am happy to see that it's already fixed! I'm new to Thymeleaf and so far am liking it and the Layout dialect very much.