Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted datasets update to cache_labels() #4845

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 17, 2021

PR should produce datasets sorted alphabetically by filename. Cache version incremented to 0.5.

Note: will force a one-time re-caching of existing datasets on first-use.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved image and label scanning process in YOLOv5 dataset caching.

📊 Key Changes

  • Replaced imap_unordered with imap function in the dataset labeling process.
  • Updated cache version from 0.4 to 0.5.

🎯 Purpose & Impact

  • 🎯 The switch to imap enforces the order during multiprocessing, which can help in maintaining consistency.
  • 📈 By incrementing the cache version, users are informed of an update that possibly includes new features or bug fixes. Users can expect a slight change in how the dataset caching system works, potentially improving their experience with data processing.

PR should produce datasets sorted alphabetically by filename. Cache version incremented to 0.5. 

Note: will force a one-time re-caching of existing datasets on first-use.
@glenn-jocher glenn-jocher self-assigned this Sep 17, 2021
@glenn-jocher
Copy link
Member Author

@kalenmike should resolve dataset ordering issue for new HUB JSONs.

@glenn-jocher glenn-jocher merged commit fe39562 into master Sep 17, 2021
@glenn-jocher glenn-jocher deleted the update/cache_05 branch September 17, 2021 15:35
glenn-jocher added a commit that referenced this pull request Sep 17, 2021
Defines dataset labels *.cache version in a single place, fixing a bug introduced in #4845.
glenn-jocher added a commit that referenced this pull request Sep 17, 2021
Defines dataset labels *.cache version in a single place, fixing a bug introduced in #4845.
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
PR should produce datasets sorted alphabetically by filename. Cache version incremented to 0.5. 

Note: will force a one-time re-caching of existing datasets on first-use.
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
Defines dataset labels *.cache version in a single place, fixing a bug introduced in ultralytics#4845.
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
PR should produce datasets sorted alphabetically by filename. Cache version incremented to 0.5. 

Note: will force a one-time re-caching of existing datasets on first-use.
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Defines dataset labels *.cache version in a single place, fixing a bug introduced in ultralytics#4845.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant