Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi_label option for NMS with PyTorch Hub #4728

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Allow multi_label option for NMS with PyTorch Hub #4728

merged 2 commits into from
Sep 9, 2021

Conversation

jeanbmar
Copy link
Contributor

@jeanbmar jeanbmar commented Sep 9, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced Non-Maximum Suppression (NMS) with multi-label support in YOLOv5.

πŸ“Š Key Changes

  • Added a new parameter multi_label to the AutoShape class.
  • Updated the forward method to use the new multi_label parameter during NMS.

🎯 Purpose & Impact

  • 🎯 Purpose: To allow each detected bounding box to have multiple class labels assigned during the NMS process, enhancing the model's ability to recognize multiple objects within the same region.
  • πŸ” Impact: Users will benefit from more versatile object detection, particularly in images where objects of different categories overlap. This update may also improve the model's overall accuracy and performance in complex scenarios.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @jeanbmar, thank you for submitting a πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • βœ… Verify all Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher glenn-jocher changed the title Allow specifying multi_label option for NMS when using torch hub Allow multi_label option for NMS with PyTorch Hub Sep 9, 2021
@glenn-jocher glenn-jocher merged commit 1cad0ce into ultralytics:master Sep 9, 2021
@jeanbmar
Copy link
Contributor Author

jeanbmar commented Sep 9, 2021

Thank you for the quick review and merge!

positive666 referenced this pull request in positive666/yolo_research Sep 10, 2021
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Allow specifying multi_label option for NMS when using torch hub

* Reformat

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Allow specifying multi_label option for NMS when using torch hub

* Reformat

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants