Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese README #10465

Merged
merged 13 commits into from
Dec 13, 2022
Merged

Fix Chinese README #10465

merged 13 commits into from
Dec 13, 2022

Conversation

Nioolek
Copy link
Contributor

@Nioolek Nioolek commented Dec 11, 2022

Hello, YOLOv5 has been very popular among Chinese users. However, I found some incomprehensible and mistranslated points in the Chinese document. I will refine this document as much as possible.

I haven't finished all the work yet. Please do not merge this PR.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Update to translation workflow and enhancements in YOLOv5 documentation and segmentation models.

📊 Key Changes

  • Translation workflow now triggers on pushes to translate_readme branch rather than main or master.
  • Updated video link in README files to a new tutorial or demo video.
  • Enhanced segmentation model details with the inclusion of YOLOv5m-seg and YOLOv5l-seg models.
  • Various sections in the README have been tidied up, including Inference, Install, Training, and Tutorials.

🎯 Purpose & Impact

  • 🚀 The workflow change allows for controlled translation updates, likely for testing.
  • 📹 Providing current video content improves user experience and aids in understanding YOLOv5 usage.
  • 💡 Additional segmentation model details offer users more options and information for their computer vision tasks.
  • 📚 Improved documentation structure enhances readability and user navigation, facilitating a smoother onboarding experience for new users.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @Nioolek, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

@AyushExel
Copy link
Contributor

@Nioolek thanks for helping out on this.

@Nioolek
Copy link
Contributor Author

Nioolek commented Dec 12, 2022

@Nioolek thanks for helping out on this.

Hello, I have finished modifying the document. You can review this PR.

Disable auto-translation by changing on-push branch to 'translate_readme'. This prevents overwriting of manual fixes.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher
Copy link
Member

@Nioolek thanks!

@Laughing-q could you take a look and let me know if this is good to merge? Thanks!

@Laughing-q
Copy link
Member

Laughing-q commented Dec 13, 2022

@Nioolek
Ultralytics Live Session Ep。 2 将在 欧洲中部时间 12 月 13 日星期二的 19:00 ,通过 Joseph Nelson 的 Roboflow 直播 这里应该改成Ultralytics Live Session EP. 2将与Roboflow的Joseph Nelson在欧洲中部时间12月13日星期二的19:00直播
Thanks!

@glenn-jocher generally look good! expect there's a tiny issue in the live info part which I point above. It's ready to merge after this part fixed.

@Nioolek
Copy link
Contributor Author

Nioolek commented Dec 13, 2022

与Roboflow的Joseph Nel

@glenn-jocher @Laughing-q
Hello, I have fixed thie part.

@Laughing-q
Copy link
Member

@Nioolek thanks!
then it's ready to merge. :) @glenn-jocher

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher changed the title Beautify Chinese Documents Fix Chinese README Dec 13, 2022
@glenn-jocher glenn-jocher merged commit 1752768 into ultralytics:master Dec 13, 2022
@glenn-jocher
Copy link
Member

@Nioolek @Laughing-q PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants