Skip to content

Multi-page demo #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Multi-page demo #53

wants to merge 1 commit into from

Conversation

@glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 23, 2025 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Adds a reusable shared stylesheet and a new multi-page web demo to validate that the Ultralytics Chat widget persists across page navigations.

📊 Key Changes

  • ➕ Introduces examples/web/demo-multi.html, a dedicated multi-page chat widget demo that exercises navigation between pages while keeping the chat pill/session alive.
  • 🎨 Extracts and centralizes shared demo styling into examples/web/demo.css, replacing the large inline <style> block in demo.html with a <link> reference.
  • 🔗 Updates demo.html toolbar to include a navigation button linking to the new multi-page demo, and cross-links from the multi-page demo back to the single-page demo.

🎯 Purpose & Impact

  • 🧪 Provides a clear reproduction environment for navigation-related issues where frameworks replace <head>/<body> and might disrupt the chat widget DOM.
  • 🧩 Improves maintainability and consistency of the web demos by consolidating styling into a single shared CSS file.
  • 💬 Helps verify that chat UI elements, theme, and sessions persist seamlessly across page navigations, reducing regressions for integrators using multi-page apps.

@vercel
Copy link

vercel bot commented Nov 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
llm Ready Ready Preview Comment Nov 23, 2025 4:16pm

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Nov 23, 2025
@UltralyticsAssistant
Copy link
Member

UltralyticsAssistant commented Nov 23, 2025

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/llm 🚀 PR! This is an automated review assistant, and a human engineer will be with you soon. In the meantime, please review the checklist below:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/llm main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. If you have any questions, feel free to leave a comment and the team will be happy to help. Thank you for contributing to Ultralytics! 🚀

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

UltralyticsAssistant
UltralyticsAssistant reviewed Nov 23, 2025
View reviewed changes
Copy link
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Add the missing HTML5 DOCTYPE to demo-multi.html to keep the new multi-page demo rendering in standards mode like the existing single-page version.

💬 Posted 1 inline comment

examples/web/demo-multi.html
@@ -0,0 +1,176 @@
<!-- Ultralytics 🚀 AGPL-3.0 License - https://ultralytics.com/license -->

<html lang="en" data-theme="light">
Copy link
Member

@UltralyticsAssistant UltralyticsAssistant Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ HIGH: The new page is missing a <!DOCTYPE html> declaration. Without it, browsers can fall back to quirks mode, which causes inconsistent layout/box-model behavior compared to the single-page demo. Add the HTML5 DOCTYPE before the opening <html> tag so both demos render in standards mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UltralyticsAssistant UltralyticsAssistant UltralyticsAssistant left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glenn-jocher @UltralyticsAssistant