Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ulid/javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0
Choose a base ref
...
head repository: ulid/javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.1
Choose a head ref
  • 6 commits
  • 3 files changed
  • 3 contributors

Commits on Apr 2, 2025

  1. Update utils.ts

    Hi @j0pgrm, re #81
    
    Your `if` statement is there to cover the possbility that your PRNG will generate the number 1. 
    In general, PRNGs produce values from 0 to _less than_ 1, i.e. from the range 0 (inclusive) to 1 (exclusive). This is because when they generate an N-bit binary fraction, the highest value (all `1`s) will be just a tiny bit smaller than 1.
    
    Your `Math.floor` correctly rounds downward, so that `rand` will be in the range 0 (inclusive) to ENCODING_LEN *- 1* (inclusive). 
    So the `if` will never be triggered.
    
    If, for some reason, you in future switch to a prng that somehow can generate a 1, for example because it has an idiosyncratic desire to cover a range of 0 (_exclusive_) to 1 (_inclusive_), then:
    
    * the chance of this is extremely small (1 in 2**N, not 1 in 2**8)
    * the PRNG will have lost the ability to generate 0
    * your random character generator would have a micrscopically smaller chance of generating the first encoding character, and have a microscopic chance of trying to pick the non-existent character at #ENCODING_LEN.
    
    A neat solution for you is to simply wrap round that exactly-1 PRNG value back to 0, most conveniently  A simple way to achieve this is to modulo the `rand` by ENCODING_LEN.
    
    
    
    Thank you for an excellent library.
    darrelfrancis authored Apr 2, 2025
    Configuration menu
    Copy the full SHA
    d44c3d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2025

  1. Fix typo

    perry-mitchell authored Jun 8, 2025
    Configuration menu
    Copy the full SHA
    5c14ac9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #120 from darrelfrancis/master

    Resolve #81 to deal with a potential future scenario of PRNG generating `1`
    perry-mitchell authored Jun 8, 2025
    Configuration menu
    Copy the full SHA
    63784e2 View commit details
    Browse the repository at this point in the history
  3. Fix formatting

    perry-mitchell committed Jun 8, 2025
    Configuration menu
    Copy the full SHA
    b17312d View commit details
    Browse the repository at this point in the history
  4. Update dependencies

    perry-mitchell committed Jun 8, 2025
    Configuration menu
    Copy the full SHA
    fe3953d View commit details
    Browse the repository at this point in the history
  5. 3.0.1

    perry-mitchell committed Jun 8, 2025
    Configuration menu
    Copy the full SHA
    ab232d7 View commit details
    Browse the repository at this point in the history
Loading