Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Warning console avec portal (firefox) #446

Open
jsroy19 opened this issue Dec 4, 2020 · 1 comment
Open

Warning console avec portal (firefox) #446

jsroy19 opened this issue Dec 4, 2020 · 1 comment

Comments

@jsroy19
Copy link
Contributor

jsroy19 commented Dec 4, 2020

Description du bogue / Describe the bug
à l'initialisation de la page dans Brio, il y a des warnings console de "empty string passe to getElementById" dans portal.ts (sous Firefox) en mode developpement.

Solution
remplacer dans portal.ts
private propId: string ='';

par un getter :
private get propId(): string {return this.id === undefined ? 'mPortal-' + uuid.generate() : this.id; }

et retirer l'initialisaiton de this.propId dans la méthode "ensutePortalTargetEl

Il est possible que les storybook du "toast" plantent, simplement les updater après avoir mis "open="true"" dans le template

@jsroy19
Copy link
Contributor Author

jsroy19 commented Dec 4, 2020

changements effectués dans brio :
https://crucible.ulaval.ca/cru/CR-ENA2-UI-3399#CFR-293792

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant