[~] - update ami to amazon linux 2 #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rraub
suggested changes
Nov 15, 2019
| @@ -152,7 +158,7 @@ resource "aws_security_group" "rabbitmq_nodes" { | |||
|
|
|||
| resource "aws_launch_configuration" "rabbitmq" { | |||
| name = local.cluster_name | |||
| image_id = data.aws_ami_ids.ami.ids[0] | |||
| image_id = data.aws_ami.amazon-linux-2.id | |||
There was a problem hiding this comment.
Suggested change
| image_id = data.aws_ami.amazon-linux-2.id | |
| image_id = data.aws_ami_ids.amazon-linux-2.ids[0] |
| owners = ["amazon"] | ||
| data "aws_ami" "amazon-linux-2" { | ||
| owners = ["amazon"] | ||
| most_recent = true |
There was a problem hiding this comment.
Suggested change
| most_recent = true |
This isn't an valid attribute, https://www.terraform.io/docs/providers/aws/d/ami_ids.html#sort_ascending is probably what you were thinking of but that defaults to descending which is what we want.
|
Also this ami broke the |
|
Hey @oreststetsiak, thank you for PR and @rraub for comments. Currently we don't have resources to prepare CI pipeline with some basic tests or to do tests manually. If you have some spare time and could help here, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update ami to amazon linux 2