🐛 Fix stacked plots functionality by ensuring multiple output var…#4068
Open
chris-ashe wants to merge 2 commits intomainfrom
Open
🐛 Fix stacked plots functionality by ensuring multiple output var…#4068chris-ashe wants to merge 2 commits intomainfrom
chris-ashe wants to merge 2 commits intomainfrom
Conversation
…es are handled correctly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4068 +/- ##
==========================================
- Coverage 46.60% 46.46% -0.14%
==========================================
Files 122 122
Lines 28711 28839 +128
==========================================
+ Hits 13381 13401 +20
- Misses 15330 15438 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Jan 29, 2026
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Can you give me an example of the bug this fixes please (an MFile + commands to run)... its not immediately obvious what the problem was and how this fixes it.
process/io/plot_scans.py
Outdated
| sharex=True, | ||
| ) | ||
| fig.subplots_adjust(hspace=0.0) | ||
| pass |
Collaborator
There was a problem hiding this comment.
Please rewrite this if statement to avoid just having a pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for handling stacked plots in the
mainfunction ofprocess/io/plot_scans.py. The main improvement is to ensure that subplots for stacked plots are created only once, and only when needed, thereby fixing potential issues with subplot creation and improving code clarity.Plotting logic improvements:
fig, axs = plt.subplots(...)) from the outer loop to occur only once, at the first relevant iteration, preventing redundant subplot creation and related errors.passstatement, since subplot creation is now handled inside the plotting logic.ValueErrorif stacked plots are requested with only one output variable, ensuring proper usage and error handling.…iables are handled correctlyDescription
Checklist
I confirm that I have completed the following checks: