fix(check_peer_dependencies): use node module resolution to find dependencies

No longer assumes that all packages are installed flat in the root node_modules
Use 'resolve' npm module to discover dependencies' package.json

Author: christopherthielen

check_peer_dependencies.js

@@ -1,8 +1,9 @@
 #!/usr/bin/env node
-
 const fs = require('fs');
+const path = require('path');
 const semver = require('semver');
 const util = require('./util');
+const resolve = require('resolve');
 const yargs = require('yargs')
     .option('help', {
       alias: 'h',
@@ -43,7 +44,7 @@ const visitedDeps = [];
 const peerDeps = [];
 
 const rootPackageJson = readFile(PACKAGEJSON);
-checkInstalledPackage(rootPackageJson);
+checkInstalledPackage(".", null);
 
 function getDependencies(packageJson) {
   const { name, dependencies = {}, peerDependencies = {} } = packageJson;
@@ -54,8 +55,31 @@ function getDependencies(packageJson) {
   };
 }
 
+function getPackagePath(basedir, packageName) {
+  let packagePath;
+  function packageFilter (pkg, pkgfile, dir) {
+    packagePath = pkgfile;
+    return pkg;
+  }
+  try {
+    resolve.sync(packageName, { basedir, packageFilter });
+  } catch (ignored) {
+    // resolve.sync throws if no main: is present
+    // Some packages (such as @types/*) do not have a main
+    // As long as we have a packagePath, it's fine
+  }
+  return packagePath;
+}
+
+function checkInstalledPackage(basedir, packageName) {
+  if (resolve.isCore(packageName)) {
+    return;
+  }
+
+  const packagePath = packageName ? getPackagePath(basedir, packageName) : basedir;
+  const packageJsonPath = path.join(packagePath, PACKAGEJSON);
+  const packageJson = readFile(packageJsonPath);
 
-function checkInstalledPackage(packageJson) {
   const { name, dependencies, peerDependencies } = getDependencies(packageJson);
   if (visitedDeps.includes(name)) {
     return;
@@ -67,11 +91,7 @@ function checkInstalledPackage(packageJson) {
   });
 
   dependencies.forEach(dependency => {
-    const dependencyName = dependency.name;
-    const installedPkgDir = `${NODEMODULES}/${dependencyName}`;
-    const nestedPkgJson = `${installedPkgDir}/${PACKAGEJSON}`;
-    const nestedPkg = readFile(nestedPkgJson);
-    checkInstalledPackage(nestedPkg)
+    checkInstalledPackage(packagePath, dependency.name)
   });
 }
 

package.json

@@ -30,6 +30,7 @@
     "util": "./util.js"
   },
   "dependencies": {
+    "@types/resolve": "0.0.8",
     "conventional-changelog": "^3.1.10",
     "conventional-changelog-ui-router-core": "^1.4.2",
     "find-parent-dir": "^0.3.0",
@@ -39,6 +40,7 @@
     "npm-run-all": "^4.1.5",
     "open": "^6.4.0",
     "readline-sync": "^1.4.10",
+    "resolve": "^1.12.0",
     "shelljs": "^0.8.3",
     "shx": "^0.3.1",
     "tmp": "^0.1.0",

yarn.lock

@@ -6,6 +6,18 @@
   version "3.0.3"
   resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.3.tgz#3dca0e3f33b200fc7d1139c0cd96c1268cadfd9d"
 
+"@types/node@*":
+  version "12.7.12"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.12.tgz#7c6c571cc2f3f3ac4a59a5f2bd48f5bdbc8653cc"
+  integrity sha512-KPYGmfD0/b1eXurQ59fXD1GBzhSQfz6/lKBxkaHX9dKTzjXbK68Zt7yGUxUsCS1jeTy/8aL+d9JEr+S54mpkWQ==
+
+"@types/resolve@0.0.8":
+  version "0.0.8"
+  resolved "https://registry.yarnpkg.com/@types/resolve/-/resolve-0.0.8.tgz#f26074d238e02659e323ce1a13d041eee280e194"
+  integrity sha512-auApPaJf3NPfe18hSoJkp8EbZzer2ISk7o8mCC3M9he/a04+gbMF97NkpD2S8riMGvm4BMRI59/SZQSaLTKpsQ==
+  dependencies:
+    "@types/node" "*"
+
 JSONStream@^1.0.4:
   version "1.3.3"
   resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.3.tgz#27b4b8fbbfeab4e71bcf551e7f27be8d952239bf"
@@ -1116,6 +1128,11 @@ path-parse@^1.0.5:
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.5.tgz#3c1adf871ea9cd6c9431b6ea2bd74a0ff055c4c1"
 
+path-parse@^1.0.6:
+  version "1.0.6"
+  resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.6.tgz#d62dbb5679405d72c4737ec58600e9ddcf06d24c"
+  integrity sha512-GSmOT2EbHrINBf9SR7CDELwlJ8AENk3Qn7OikK4nFYAu3Ote2+JYNVvkpAEQm3/TLNEJFD/xZJjzyxg3KBWOzw==
+
 path-type@^1.0.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/path-type/-/path-type-1.1.0.tgz#59c44f7ee491da704da415da5a4070ba4f8fe441"
@@ -1296,6 +1313,13 @@ resolve@^1.1.6:
   dependencies:
     path-parse "^1.0.5"
 
+resolve@^1.12.0:
+  version "1.12.0"
+  resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.12.0.tgz#3fc644a35c84a48554609ff26ec52b66fa577df6"
+  integrity sha512-B/dOmuoAik5bKcD6s6nXDCjzUKnaDvdkRyAk6rsmsKLipWj4797iothd7jmmUhWTfinVMU+wc56rYKsit2Qy4w==
+  dependencies:
+    path-parse "^1.0.6"
+
 rimraf@^2.6.3:
   version "2.7.1"
   resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec"