Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS ARM pre-compiled binaries #164

Closed
JamieMagee opened this issue Apr 16, 2023 · 6 comments
Closed

macOS ARM pre-compiled binaries #164

JamieMagee opened this issue Apr 16, 2023 · 6 comments
Assignees

Comments

@JamieMagee
Copy link
Contributor

GitHub hosted runners for macOS ARM are currently in public preview1. Whenever they go GA, would be be possible to pre-compile node-re2 binaries for them?

Footnotes

  1. https://github.com/github/roadmap/issues/528

@uhop
Copy link
Owner

uhop commented Apr 17, 2023

That would be awesome. When they are available, I’ll try.

@uhop uhop self-assigned this Apr 17, 2023
@uhop
Copy link
Owner

uhop commented May 25, 2023

@uhop uhop closed this as completed May 25, 2023
@uhop
Copy link
Owner

uhop commented May 25, 2023

For now, I do them manually from my laptop.

@viceice
Copy link

viceice commented Jul 12, 2023

what's the difference between the darwin builds and the arm64 builds. We've again some issues with re2 being very slow because it needs to be rebuild on our linux/arm64 docker images

#6 115.1 npm ERR! Trying https://github.com/uhop/node-re2/releases/download/1.19.1/linux-arm64-108.br ...
#6 115.1 npm ERR! Trying https://github.com/uhop/node-re2/releases/download/1.19.1/linux-arm64-108.gz ...
#6 115.1 npm ERR! Building locally ...
#6 115.1 npm ERR!
#6 115.1 npm ERR! > re2@1.19.1 rebuild
#6 115.1 npm ERR! > node-gyp rebuild

@uhop
Copy link
Owner

uhop commented Jul 12, 2023

See https://github.com/uhop/install-artifact-from-github/wiki/Install-from-cache#command-line-parameters for more details. The page explains how a fetcher interpolates a name.

Essentially a binary extension has 3 major variables: OS, CPU, and ABI. ABI is more-or-less a Node version, e.g., Node 19 and Node 20 have different ABIs.

I don’t do builds outside of standard runners provided by GitHub Actions. I ran a custom build on my laptop for darwin-arm64. It looks like you have a suitable custom runner. I suggest you exploring a private mirror: https://github.com/uhop/node-re2/wiki/Precompiled-versions#private-mirrors

It will allow you to build the linux-arm64 version and reuse it across your worker images.

@viceice
Copy link

viceice commented Jul 13, 2023

ok, will try that mirror thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants