-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regex project file parameter #2945
Conversation
// TODO: insert rank into regex for mpi case | ||
DBUG("vtkdiff regex is '{}'.", *regex_string); | ||
auto const regex = std::regex(*regex_string); | ||
for (auto& p: fs::directory_iterator(fs::path(reference_path))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's good. The file names are taken from the reference directory.
I'll provide a script to convert |
So long I'm busy with the converter maybe there are some comments about the extension. Would be nice! |
IMHO it is a useful extension. Will do a review when the status is changed from Draft to PR. |
Replaced all "GLOB"bed RichardsMechanics tests with prj-file Generation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small questions only. Then ⏩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead with the remaining conversion!
Can be used inside a project file similar to the glob expression in AddTest() (CMake). If the regex-parameter is present, the `file`- parameter is ignored and can be omitted.
Move test's definition into the project file.
Store commands to shell script to be executed once.
And replace AddTest calls to OgsTest in cmake.
All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
OpenGeoSys development has been moved to GitLab. |
Adds a
regex
project file parameter to thevtkdiff
-section.The main idea is to put the test tolerances/criteria together with the project files. Currently it is possible by specifying individual files to be compared, which is a little lengthy. With globbing this shall become much easier.
TODO: