[HM] enable mass lumping #2826
Merged
[HM] enable mass lumping #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
reviewed
Feb 28, 2020
|
Do the ctests give different results when mass-lumping is used? |
|
@endJunction Yes, all tests passed |
endJunction
reviewed
Feb 29, 2020
Comment on lines
308
to
313
| for (int idx_ml = 0; idx_ml < storage_p.cols(); idx_ml++) | ||
| { | ||
| double const mass_lump_val = storage_p.col(idx_ml).sum(); | ||
| storage_p.col(idx_ml).setZero(); | ||
| storage_p(idx_ml, idx_ml) = mass_lump_val; | ||
| } |
There was a problem hiding this comment.
No need for the for-loop. It is included in Eigen through the colwise() operator. See RM-FEM.
storage_p = storage_p.colwise().sum().eval().asDiagonal();There was a problem hiding this comment.
You're absolutely right. I updated the code.
endJunction
approved these changes
Feb 29, 2020
TomFischer
approved these changes
Mar 2, 2020
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the option to use mass lumping in HM which can help with oscillation problems