Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM/HM/LIE-HM interpolated pressure #2228

Merged
merged 9 commits into from
Oct 1, 2018
Merged

RM/HM/LIE-HM interpolated pressure #2228

merged 9 commits into from
Oct 1, 2018

Conversation

endJunction
Copy link
Member

Move LIE/HM interpolate_pressure to NumLib::interpolateToHigherOrderNodes.

Use in RichardsMechanics and HydroMechanics processes.

Copy link
Collaborator

@chleh chleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor comments.

///
/// The base nodes' values are copied. For each higher order node the shape
/// matrices are evaluated for the lower order element (the base nodes), and
/// used for the the scalar quantity interpolation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be mentioned that the node_values belong to a scalar field.

{
// Evaluated at higher order nodes' coordinates.
fe.template computeShapeFunctions<ShapeMatrixType::N>(
NaturalCoordinates<HigherOrderMeshElementType>::coordinates[n]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HigherOrderMeshElementType is the "true" type of element, isn't it? Maybe that could be commented
or asserted: assert(dynamic_cast<HigherOrderMeshElementType*>(&element));.

.data(),
shape_matrices, GlobalDim, is_axially_symmetric);

std::size_t const global_index = element.getNodeIndex(n);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that work with domain decomposition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, because the node numbering is local for each partition, and so are the mesh properties...

@endJunction endJunction merged commit 6cd1259 into ufz:master Oct 1, 2018
@endJunction endJunction deleted the RMInterpolatedPressure branch October 1, 2018 15:07
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants