Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More analyzers (cppcheck, clang-tidy, iwyu) #2078

Merged
merged 7 commits into from
Feb 15, 2018
Merged

Conversation

bilke
Copy link
Member

@bilke bilke commented Feb 14, 2018

Added more analyzers to a master-only subjob:

See example output. Unfortunately the warnings are not reported / summarized somewhere at the moment. CDash implements that and is under investigation ...

Other changes:

To discuss:

iwyu suggests to include

#include <logog/include/macro.hpp>                     // for INFO, WARN
#include <logog/include/message.hpp>                   // for Message

instead of of just logog/include/logog.hpp. Should we do it like this, otherwise we have to somehow silence this warning.

@@ -0,0 +1,3 @@
---
# Disable all checks, one check has to be enabled (hack)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the hack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no enabled check clang-tidy (at least in the way it is invoked by CMake) prints out its usage instructions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find another way to specify that this folder should be ignored.

Copy link
Member

@endJunction endJunction Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I neither do know. ;(
Just add this comment to the "hack", so we are not wondering why...

@endJunction
Copy link
Member

endJunction commented Feb 14, 2018

"somehow silence." I don't remember the options, but iwyu can be told to use that specific include file instead of the others... Maybe over a config file. Or enforce keeping that include, smth like:

#include "logog.h" // IWYU_special_keep_this_always.

@endJunction endJunction merged commit 0cbfc9a into ufz:master Feb 15, 2018
@bilke bilke deleted the analyzers branch February 15, 2018 14:22
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants