-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More analyzers (cppcheck, clang-tidy, iwyu) #2078
Conversation
ThirdParty/.clang-tidy
Outdated
@@ -0,0 +1,3 @@ | |||
--- | |||
# Disable all checks, one check has to be enabled (hack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no enabled check clang-tidy (at least in the way it is invoked by CMake) prints out its usage instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find another way to specify that this folder should be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I neither do know. ;(
Just add this comment to the "hack", so we are not wondering why...
✅
"somehow silence." I don't remember the options, but iwyu can be told to use that specific include file instead of the others... Maybe over a config file. Or enforce keeping that include, smth like: #include "logog.h" // IWYU_special_keep_this_always. ✅ |
OpenGeoSys development has been moved to GitLab. |
Added more analyzers to a master-only subjob:
See example output. Unfortunately the warnings are not reported / summarized somewhere at the moment. CDash implements that and is under investigation ...
Other changes:
To discuss:
iwyu suggests to include
instead of of just
logog/include/logog.hpp
. Should we do it like this, otherwise we have to somehow silence this warning.