Implementation of HC process #1758

TomFischer · 2017-04-05T09:12:20Z

Missing things:

Documentation of parameters
~~Documentation of benchmarks~~ Marc is working on this, however code review can start.
goswamy benchmark

For discussion:

process name: HC or ComponentTransport or ...
search length for boundary conditions

Update Changing the default search length breaks the benchmark 'ogs-TES_zeolite_discharge_small'. So I removed the commit.

wenqing · 2017-04-21T09:57:41Z

ProcessLib/ComponentTransport/ComponentTransportFEM.h

+                                          p_nodal_values);
+
+            double const velocity_magnitude = velocity.norm();
+            GlobalDimMatrixType const& I(


The definition, GlobalDimMatrixType const& I, can be moved to before the start of this loop. ✅

wenqing · 2017-04-21T11:18:14Z

ProcessLib/ComponentTransport/ComponentTransportFEM.h

+            auto const retardation_factor =
+                _process_data.retardation_factor(t, pos)[0];
+
+            auto KCC = local_K.template block<num_nodes, num_nodes>(0, 0);


It is possible to move lines 183 to 189 about the matrix blocks before the start of the integration loop? ✅

wenqing · 2017-04-21T11:26:15Z

ProcessLib/ComponentTransport/CreateComponentTransportProcess.cpp

+    PorousMediaProperties porous_media_properties{
+        createPorousMediaProperties(mesh, porous_medium_configs)};
+
+    //! \ogs_file_param{prj__processes__process__ComponentTransport__fluid}


Suggest to use class FluidProperties, which contains density, viscosity, specific heat capacity and thermal conductivity (optional). There is a creator for FluidProperties, please see
https://github.com/ufz/ogs/blob/master/ProcessLib/LiquidFlow/CreateLiquidFlowMaterialProperties.cpp#L49

wenqing · 2017-04-21T11:34:11Z

ProcessLib/ComponentTransport/CreatePorousMediaProperties.cpp

+{
+namespace ComponentTransport
+{
+PorousMediaProperties createPorousMediaProperties(


👍 . This class can be general one for all fluid flow processes. After this PR merged, I may refractory the other flow processes by using this class to reduce the source code duplication about porous medium among process classes.

wenqing · 2017-04-21T11:39:46Z

ProcessLib/ComponentTransport/ComponentTransportProcessData.h

+    void operator=(ComponentTransportProcessData&&) = delete;
+
+    PorousMediaProperties porous_media_properties;
+    std::unique_ptr<MaterialLib::Fluid::FluidProperty> viscosity_model;


As the comment given about, you can replace

std::unique_ptr<MaterialLib::Fluid::FluidProperty> viscosity_model; std::unique_ptr<MaterialLib::Fluid::FluidProperty> fluid_density;

with

const std::unique_ptr<MaterialLib::Fluid::FluidProperties> _fluid_properties;

Here is an example to use FluidProperties:
https://github.com/ufz/ogs/blob/master/ProcessLib/LiquidFlow/LiquidFlowMaterialProperties.cpp#L75

TomFischer · 2017-04-24T11:06:11Z

I compared the run times on my laptop with and without the last commit (c0bfb08). The previous version (without FluidProperties) takes circa 79 seconds while the new version takes ~ 81.6 seconds.

wenqing · 2017-04-24T12:16:16Z

@TomFischer If the fluid properties do not depend on density, the extra operation to access members of individual fluid property class is to access an entry of the property array

const std::array<std::unique_ptr<FluidProperty>, FluidPropertyTypeNumber>
        _property_models;

class FluidProperties enables the temperature density dependent fluid property models, e.g. WaterViscosityIAPWS.

wenqing

👍

endJunction · 2017-04-25T21:42:09Z

MaterialLib/Fluid/PropertyVariableType.h

@@ -22,7 +22,8 @@ enum class PropertyVariableType
    T = 0,                   ///< temperature.
    p = 1,                   ///< pressure.
    rho = p,                 ///< density. For some models, rho substitutes p
-    number_of_variables = 2  ///< Number of property variables.
+    C = 2,


short comment

endJunction · 2017-04-25T21:47:23Z

ProcessLib/ComponentTransport/ComponentTransportFEM.h

+                MaterialLib::Fluid::PropertyVariableType::C)] = C_int_pt;
+            vars[static_cast<int>(
+                MaterialLib::Fluid::PropertyVariableType::p)] = p_int_pt;
+            auto const density_water = _process_data.fluid_properties->getValue(


better to call it density_fluid (or simply density, if there is no other), it's not always water...

endJunction · 2017-04-25T21:50:44Z

ProcessLib/ComponentTransport/ComponentTransportFEM.h

+                _process_data.fluid_properties->getValue(
+                    MaterialLib::Fluid::FluidPropertyType::Viscosity, vars);
+
+            GlobalDimMatrixType const perm_over_visc =


Better to call it K_over_mu as it is done below.

endJunction · 2017-04-25T21:55:53Z

ProcessLib/ComponentTransport/CreateComponentTransportProcess.cpp

+        std::move(porous_media_properties),
+//        std::move(viscosity_model),
+        fluid_reference_density,
+//        std::move(fluid_density),


drop the comments or explain why needed

endJunction · 2017-04-25T21:56:47Z

ProcessLib/ComponentTransport/CreatePorousMediaProperties.cpp

+                permeability_conf));
+
+        // Parameter for the specific storage.
+        auto const& storage_conf =


typo: config ;)
and the comment above is misleading...

endJunction · 2017-04-25T21:58:19Z

ProcessLib/ComponentTransport/PorousMediaProperties.h

+        double t, SpatialPosition const& pos) const;
+
+    Eigen::MatrixXd const& getIntrinsicPermeability(double t,
+                                              SpatialPosition const& pos) const;


maybe formatting... git clang-format ufz/master is good!

endJunction

Looks promising.

In the assembly part I'd maybe try to extract special functions for velocity computation etc....

ogsbot · 2020-06-19T12:43:44Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

TomFischer added discussion 🗣️ WIP 🏗️ labels Apr 5, 2017

TomFischer force-pushed the HC-Implementation branch 10 times, most recently from 812f833 to e4595c9 Compare April 12, 2017 07:24

TomFischer force-pushed the HC-Implementation branch 2 times, most recently from b30e0a0 to a7bb07e Compare April 18, 2017 12:51

TomFischer added please review and removed discussion 🗣️ WIP 🏗️ labels Apr 18, 2017

TomFischer force-pushed the HC-Implementation branch 3 times, most recently from 338866e to b84b66d Compare April 21, 2017 09:39

wenqing reviewed Apr 21, 2017

View reviewed changes

TomFischer force-pushed the HC-Implementation branch from b84b66d to 6cd41b0 Compare April 24, 2017 06:56

wenqing approved these changes Apr 24, 2017

View reviewed changes

TomFischer force-pushed the HC-Implementation branch from c0bfb08 to d249206 Compare April 25, 2017 06:59

endJunction reviewed Apr 25, 2017

View reviewed changes

endJunction approved these changes Apr 25, 2017

View reviewed changes

TomFischer force-pushed the HC-Implementation branch 2 times, most recently from f161f44 to d01724f Compare April 26, 2017 12:21

TomFischer added 9 commits April 27, 2017 06:04

[PL/HC] Initial commit: Move HT to HC process.

82506fd

[PL/HC] First impl. of monolithic HC process.

010e577

[Mat/Fluid] Add LinearConcentrationDependentDensitity model.

86764d5

[Mat/Fluid] Add Concentration to FluidPropertyType.

a4f84b3

[Mat/Fluid] Add concentration to PropertyVariableType.

5b16006

[Mat/Fluid] Use LinearConcentrationDependentDensitity model.

9b18d1e

[PL/HC] Change handling of body force vector.

419409b

[PL/HC] Include computation of Darcy vel.

11d7b7b

Rename HC process to ComponentTransport process.

66c2e07

TomFischer force-pushed the HC-Implementation branch from d01724f to 9c8bc69 Compare April 27, 2017 04:05

TomFischer added 6 commits April 27, 2017 06:12

[ComponentTransport] Enable tests.

c210624

Docu for concentration depenendent density.

c3a40e5

Documenation of parameters.

9fdea60

[PL/ComponentTransport] Move identity out of integration loop.

742e049

[PL] Use FluidProperties/createFluidProperties.

9c94a60

[PL/ComponentTransport] Rename vars for better readability.

4589c3c

TomFischer force-pushed the HC-Implementation branch from 9c8bc69 to 4589c3c Compare April 27, 2017 04:13

TomFischer merged commit 4a99140 into ufz:master Apr 27, 2017

TomFischer deleted the HC-Implementation branch April 27, 2017 05:09

TomFischer removed the please review label Apr 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of HC process #1758

Implementation of HC process #1758

TomFischer commented Apr 5, 2017 •

edited

Loading

wenqing Apr 21, 2017 •

edited by TomFischer

Loading

wenqing Apr 21, 2017 •

edited by TomFischer

Loading

wenqing Apr 21, 2017

wenqing Apr 21, 2017

wenqing Apr 21, 2017

TomFischer commented Apr 24, 2017

wenqing commented Apr 24, 2017

wenqing left a comment

endJunction Apr 25, 2017

endJunction Apr 25, 2017 •

edited

Loading

endJunction Apr 25, 2017

endJunction Apr 25, 2017

endJunction Apr 25, 2017 •

edited

Loading

endJunction Apr 25, 2017

endJunction left a comment

ogsbot commented Jun 19, 2020

Implementation of HC process #1758

Implementation of HC process #1758

Conversation

TomFischer commented Apr 5, 2017 • edited Loading

wenqing Apr 21, 2017 • edited by TomFischer Loading

Choose a reason for hiding this comment

wenqing Apr 21, 2017 • edited by TomFischer Loading

Choose a reason for hiding this comment

wenqing Apr 21, 2017

Choose a reason for hiding this comment

wenqing Apr 21, 2017

Choose a reason for hiding this comment

wenqing Apr 21, 2017

Choose a reason for hiding this comment

TomFischer commented Apr 24, 2017

wenqing commented Apr 24, 2017

wenqing left a comment

Choose a reason for hiding this comment

endJunction Apr 25, 2017

Choose a reason for hiding this comment

endJunction Apr 25, 2017 • edited Loading

Choose a reason for hiding this comment

endJunction Apr 25, 2017

Choose a reason for hiding this comment

endJunction Apr 25, 2017

Choose a reason for hiding this comment

endJunction Apr 25, 2017 • edited Loading

Choose a reason for hiding this comment

endJunction Apr 25, 2017

Choose a reason for hiding this comment

endJunction left a comment

Choose a reason for hiding this comment

ogsbot commented Jun 19, 2020

TomFischer commented Apr 5, 2017 •

edited

Loading

wenqing Apr 21, 2017 •

edited by TomFischer

Loading

wenqing Apr 21, 2017 •

edited by TomFischer

Loading

endJunction Apr 25, 2017 •

edited

Loading

endJunction Apr 25, 2017 •

edited

Loading