Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve features of landing page carousel #36

Open
Brian-Magnuson opened this issue Dec 2, 2023 · 1 comment
Open

Improve features of landing page carousel #36

Brian-Magnuson opened this issue Dec 2, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Brian-Magnuson
Copy link
Contributor

Brian-Magnuson commented Dec 2, 2023

The image carousel (added in #34) has some minor issues. Mainly:

  • The carousel images cannot be accessed by right-clicking them Resolved by pointer-events: auto
    • I tried implementing a way to access the images in a new tab by inserting a link in the carousel's "legend"
    • It's not known how this affects accessibility
  • Scrolling may be awkward on touch devices
    • I've used this carousel on my personal website before and it can have some issues where vertical swiping does not scroll the page properly
    • The carousel has a prop called verticalSwipe; consider experimenting with this
  • It might not be the most visually appealing

image

Requirements

  • Improve the quality of the image carousel to address the issues above, or
  • Determine a new way to implement the image carousel
@Brian-Magnuson
Copy link
Contributor Author

In #34, we found that adding pointer-events: auto; to the img within the carousel item allows the image to be accessed by right-clicking, and that adding the preventMovementUntilSwipeScrollTolerance prop to the Carousel allows better scrolling on Google Chrome.

However, I also noticed another issue: Due to the size of the carousel, a horizontal scroll bar appears on Google Chrome. Oddly, this did not appear in Firefox. Consider fixing this as well.
image

@WillBAnders WillBAnders added the help wanted Extra attention is needed label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants